Skip to content

Commit

Permalink
[amd] in gq_ttq.mad and CODEGEN, work around the memory access crash m…
Browse files Browse the repository at this point in the history
…adgraph5#806 for HIPCC by disabling hipcc -O3, but keep -O2 (better than -O0)

The test now still succeeds!
./check_hip.exe  -p 1 8 1
  • Loading branch information
valassi committed Sep 19, 2024
1 parent 44a6b1d commit 3c2792a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ else ifeq ($(BACKEND),hip)
GPUSUFFIX = hip

# Optimization flags
override OPTFLAGS = -O0 # work around "Memory access fault" in gq_ttq for HIP #806: disable hipcc optimizations
override OPTFLAGS = -O2 # work around "Memory access fault" in gq_ttq for HIP #806: disable hipcc -O3 optimizations
GPUFLAGS = $(foreach opt, $(OPTFLAGS), $(XCOMPILERFLAG) $(opt))

# DEBUG FLAGS (for #806: see https://hackmd.io/@gmarkoma/lumi_finland)
Expand Down
2 changes: 1 addition & 1 deletion epochX/cudacpp/gq_ttq.mad/SubProcesses/cudacpp.mk
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ else ifeq ($(BACKEND),hip)
GPUSUFFIX = hip

# Optimization flags
override OPTFLAGS = -O0 # work around "Memory access fault" in gq_ttq for HIP #806: disable hipcc optimizations
override OPTFLAGS = -O2 # work around "Memory access fault" in gq_ttq for HIP #806: disable hipcc -O3 optimizations
GPUFLAGS = $(foreach opt, $(OPTFLAGS), $(XCOMPILERFLAG) $(opt))

# DEBUG FLAGS (for #806: see https://hackmd.io/@gmarkoma/lumi_finland)
Expand Down

0 comments on commit 3c2792a

Please sign in to comment.