Multiple quality of life improvements #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadim0x60
changed the title
This reverts commit 39aa6c8.
vadim0x60
changed the title
|
I added an Evaluation to work with Gymnasium |
vadim0x60
changed the title
| @@ -10,7 +10,7 @@ class Evaluation(ABC): | |||
| Produces a binary pass/fail result, a float score, and a text report | |||
| """ | |||
|
|
|||
| def __init__(self, SUT: Program, passing_score: float = 1.): | |||
| def __init__(self, SUT, passing_score: float = 1.): | |||
There was a problem hiding this comment.
Isn't SUT of type Program?
SUT is an abbreviation and it's nice to have some explanation and typing hints
Anastasiia-Grishina
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I see a stacktrace in my logs I think that something went wrong and try to debug it. In this case, this is an expected scenario