-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update to 24.1.4, add GH action workflow #51
Conversation
65cb7cb
to
fe642a3
Compare
91d8deb
to
610e5d9
Compare
src/test/java/com/vaadin/testbenchexample/junit5/AbstractJUnit5IT.java
Outdated
Show resolved
Hide resolved
An additional note: when running locally I noticed that |
Added code for closing the browsers as well |
Expected is EDIT: this happened on my local because I had the screenshot in EDIT 2: The following seems to work @Test
public void testOnePlusTwo() throws Exception {
....
String referenceId = "oneplustwo";
if (Boolean.TRUE.equals(getCommandExecutor().executeScript("return Vaadin.developmentMode;"))) {
referenceId += "-development";
} else {
referenceId += "-production";
}
generateReferenceIfNotFound(referenceId);
....
assertTrue(
"Screenshot comparison for 'oneplustwo' failed, see "
+ Parameters.getScreenshotErrorDirectory()
+ " for error images",
testBench().compareScreen(referenceId));
} |
Other than that, LGTM |
@mcollovati good point with the screenshots. Implemented. |
Fixes #53