Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to 24.1.4, add GH action workflow #51

Merged
merged 12 commits into from
Aug 8, 2023
Merged

Conversation

manolo
Copy link
Member

@manolo manolo commented Aug 6, 2023

Fixes #53

@CLAassistant
Copy link

CLAassistant commented Aug 6, 2023

CLA assistant check
All committers have signed the CLA.

@manolo manolo force-pushed the gh-actions branch 3 times, most recently from 65cb7cb to fe642a3 Compare August 6, 2023 12:41
@github-actions
Copy link

github-actions bot commented Aug 6, 2023

Test Results

22 tests   20 ✔️  2m 5s ⏱️
12 suites    2 💤
12 files      0

Results for commit 071c6ca.

♻️ This comment has been updated with latest results.

@manolo manolo force-pushed the gh-actions branch 2 times, most recently from 91d8deb to 610e5d9 Compare August 6, 2023 12:54
@vaadin vaadin deleted a comment from github-actions bot Aug 6, 2023
@manolo manolo changed the title chore: update to 24.1.4 and add GH action chore: update to 24.1.4, add GH action workflow Aug 6, 2023
.github/workflows/validation.yml Show resolved Hide resolved
.github/workflows/validation.yml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
pom.xml Show resolved Hide resolved
@mcollovati
Copy link

An additional note: when running locally I noticed that SimpleCaseIT and WrongBrowserIT leave some browser windows open after the test execution is completed.
I don't know if it is something missing on this project tests (for SimpleCaseIT we should probably call driver.close()) or a potential bug in Testbench (WrongBrowserIT seems to keep the browser open if the test is skipped because of an assumption, like Assumptions.assumeTrue(....))

@manolo
Copy link
Member Author

manolo commented Aug 7, 2023

Added code for closing the browsers as well

@mcollovati
Copy link

mcollovati commented Aug 8, 2023

ScreenshotIT is now failing in development mode because of the dev tools panel in the bottom right of the screen

Expected is

oneplustwo_linux_chrome_115

But the taken screenshot is
testOnePlusTwo(com vaadin testbenchexample advanced ScreenshotIT)

EDIT: this happened on my local because I had the screenshot in src/test/screenshots/oneplustwo_linux_chrome_115.png created by a previous run in production mode. Once deleted, the test passed.
However, if you then run the test in production mode, it fails for the same reason.
I wonder if we can add a dev/prod token in the reference screenshot name, to make it work correctly on both modes

EDIT 2: The following seems to work

    @Test
    public void testOnePlusTwo() throws Exception {
        ....
        String referenceId = "oneplustwo";
        if (Boolean.TRUE.equals(getCommandExecutor().executeScript("return Vaadin.developmentMode;"))) {
            referenceId += "-development";
        } else {
            referenceId += "-production";
        }
        generateReferenceIfNotFound(referenceId);
       ....
        assertTrue(
                "Screenshot comparison for 'oneplustwo' failed, see "
                        + Parameters.getScreenshotErrorDirectory()
                        + " for error images",
                testBench().compareScreen(referenceId));
    }

@mcollovati
Copy link

Other than that, LGTM

@manolo
Copy link
Member Author

manolo commented Aug 8, 2023

@mcollovati good point with the screenshots. Implemented.

@manolo manolo merged commit f2a9c25 into master Aug 8, 2023
3 checks passed
@manolo manolo deleted the gh-actions branch August 8, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PiT 24.2: make demo work with v24
3 participants