Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create vaadin-dev-flow and vaadin-dev-hilla #5264

Closed
wants to merge 4 commits into from
Closed

Conversation

caalador
Copy link
Contributor

@caalador caalador commented Apr 24, 2024

vaadin-dev no has vaadin-dev-flow and vaadin-dev-hilla.
vaadin-core depends on vaadin-dev-flow
to not get hilla if not wanted.

This will make vaadin and vaadin-core backwards
compatible with older version where hilla was not a dependency.

Implements part of #5230

Fixes #5260

vaadin-dev no has vaadin-dev-flow and
vaadin-dev-hilla.
vaadin-core depends on vaadin-dev-flow
to not get hilla if not wanted.

Fixes #5260
Copy link

github-actions bot commented Apr 24, 2024

Dependencies Report

  • 🟠 Known Vulnerabilities:

    • Vulnerabilities in: pkg:npm/[email protected] [CVE-2024-26467] (oss-bomber)
      👌 This is coming from the tools, @cyclonedx/cyclonedx-npm, we have used for sbom module, FP for us.
      ·
    • Vulnerabilities in: pkg:maven/com.fasterxml.jackson.core/[email protected] [CVE-2023-35116] (owasp)
      👌 Not a valid CVE report based on the vendor analysis and research
      · cpe:2.3:a:fasterxml:jackson-databind::::::::
    • Vulnerabilities in: pkg:maven/me.friwi/jcef-api@jcef-af53d63%2Bcef-104.4.23%2Bg46ae630%2Bchromium-104.0.5112.102 [CVE-2024-21639, CVE-2024-21640] (owasp)
      👌 Wait for the update from the jcefmaven community. Meanwhile the swing-kit is supposed to be used with fixed websites and not to browse the internet, we have a check for that, so the only possible attacker would be the same person that created the swing application, aka our customer devs. so this vulnerability is not classified by us as critical issue
      · cpe:2.3:a:chromiumembedded:chromium_embedded_framework::::::::
  • 📔 No License Issues

[Click for more Details]

pom.xml Show resolved Hide resolved
@caalador caalador marked this pull request as ready for review May 2, 2024 08:42
Comment on lines +52 to +55
<groupId>com.vaadin</groupId>
<artifactId>vaadin-dev-hilla</artifactId>
<version>${project.version}</version>
</dependency>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new dilemma: vaadin-dev-hilla is inside deps management here and it has to be added to <dependencies> in vaadin-spring-boot-starter to become a part of it. The as is structure doesn't add vaadin-dev-hilla into Vaadin Spring projects.

But if we add it, we no more could exclude it in prod mode by excluding vaadin-dev.

@mshabarov
Copy link
Contributor

An alternative solution is proposed here vaadin/hilla#2383. This PR may become a refactoring PR that doesn't move hilla-dev, but just splits vaadin-dev into two artifacts.

@mshabarov
Copy link
Contributor

This refactoring was proposed to start when we are ready for bigger changes or we have a request from users earlier with a good reason to split to vaadin-dev-flow and vaadin-dev-hilla.

@mshabarov mshabarov closed this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move hilla-dev from vaadin to vaadin-spring-boot-starter artifact in Vaadin 24.4
2 participants