-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Create vaadin-dev-flow and vaadin-dev-hilla #5264
Conversation
vaadin-dev no has vaadin-dev-flow and vaadin-dev-hilla. vaadin-core depends on vaadin-dev-flow to not get hilla if not wanted. Fixes #5260
Dependencies Report
|
<groupId>com.vaadin</groupId> | ||
<artifactId>vaadin-dev-hilla</artifactId> | ||
<version>${project.version}</version> | ||
</dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A new dilemma: vaadin-dev-hilla
is inside deps management here and it has to be added to <dependencies>
in vaadin-spring-boot-starter
to become a part of it. The as is structure doesn't add vaadin-dev-hilla
into Vaadin Spring projects.
But if we add it, we no more could exclude it in prod mode by excluding vaadin-dev
.
An alternative solution is proposed here vaadin/hilla#2383. This PR may become a refactoring PR that doesn't move |
This refactoring was proposed to start when we are ready for bigger changes or we have a request from users earlier with a good reason to split to |
vaadin-dev no has vaadin-dev-flow and vaadin-dev-hilla.
vaadin-core depends on vaadin-dev-flow
to not get hilla if not wanted.
This will make vaadin and vaadin-core backwards
compatible with older version where hilla was not a dependency.
Implements part of #5230
Fixes #5260