Migrate Makefile to Magefile #160
Conversation
rappizs
force-pushed
the
mage
branch
2 times, most recently
from
4f1ec19
to
1eac70b
Compare
Codecov Report
@@ Coverage Diff @@
## main #160 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 1 1
Lines 67 67
=====================================
Misses 67 67 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rappizs
force-pushed
the
mage
branch
11 times, most recently
from
706d939
to
9e9eb98
Compare
|
LGTM! 🙌 |
justaugustus
force-pushed
the
mage
branch
2 times, most recently
from
13df4cd
to
2b3f5ca
Compare
Signed-off-by: Zsolt Rappi <[email protected]>
Signed-off-by: Stephen Augustus <[email protected]>
justaugustus
force-pushed
the
mage
branch
4 times, most recently
from
5264d39
to
c3635b0
Compare
Signed-off-by: Stephen Augustus <[email protected]>
Signed-off-by: Stephen Augustus <[email protected]>
Signed-off-by: Stephen Augustus <[email protected]>
There was a problem hiding this comment.
Great improvement, @rappizs!
I've built on this PR a bit to integrate some patterns from some of the Kubernetes RelEng repos:
There was a problem hiding this comment.
Thanks for the refactoring @justaugustus!
I found some minor issues with the final code, could you please take a look at them? Should we create an issue for it or is it ok if I just create a PR for fixing them?
| coverProfileFilename = "unit-coverage.out" | ||
| ) | ||
|
|
||
| // All runs all targets for this repository |
There was a problem hiding this comment.
The description is a little bit misleading, since we only run two targets not all of them
| } | ||
|
|
||
| // getBuildDateTime gets the build date and time | ||
| func getBuildDateTime() string { |
There was a problem hiding this comment.
This func is not used anywhere
| } | ||
|
|
||
| // getGitState gets the state of the git repository | ||
| func getGitState() string { |
There was a problem hiding this comment.
This func is not used anywhere
| OS="${PLATFORM%/*}" | ||
| ARCH=$(basename "$PLATFORM") | ||
|
|
||
| output_name=bom'-'$OS'-'$ARCH |
There was a problem hiding this comment.
I believe bom is just a copy mistake from https://github.com/kubernetes-sigs/bom/blob/main/scripts/verify-build.sh, this should be gh-jira-issue-sync or something like that.
| } | ||
|
|
||
| // Build runs go build | ||
| func Build() error { |
There was a problem hiding this comment.
Build doesn't work on OSX, created an issue for it: #166
| fi | ||
|
|
||
| echo "Building project for $PLATFORM" | ||
| CGO_ENABLED=0 GOARCH="$ARCH" GOOS="$OS" go build -trimpath -ldflags "${GHJIRA_LDFLAGS}" -o output/$output_name ./main.go |
There was a problem hiding this comment.
The output dir is not included in the .gitignore file: #167
* feat(mage): Replace make with * magefile: Adopt patterns from Kubernetes Release Engineering repos --------- Signed-off-by: Zsolt Rappi <[email protected]> Co-authored-by: Stephen Augustus <[email protected]> Signed-off-by: matewolf <[email protected]>
* feat(mage): Replace make with * magefile: Adopt patterns from Kubernetes Release Engineering repos --------- Signed-off-by: Zsolt Rappi <[email protected]> Co-authored-by: Stephen Augustus <[email protected]> Signed-off-by: matewolf <[email protected]>
Migrated
maketomageFixes #61