Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trig recipe cleanup #217

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Trig recipe cleanup #217

wants to merge 4 commits into from

Conversation

ajpal
Copy link
Collaborator

@ajpal ajpal commented Jul 3, 2023

  1. Add panic! if run_rule_lifting doesn't find rules
  2. Restructure the trig recipe so that each phase is self-contained. I think it's easier to tell what's in each workload if there's fewer layers of plugs, and everything is local in the file. Lmk what you think!

The workloads + rules are very similar, but not identical. The new rules can derive 100% of the old rules, though, so hopefully it should be okay.

@ajpal ajpal requested a review from bksaiki July 3, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant