Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jarydo/Add Coordinates to User #97

Merged
merged 12 commits into from
Oct 20, 2023
Merged

jarydo/Add Coordinates to User #97

merged 12 commits into from
Oct 20, 2023

Conversation

jarydo
Copy link
Contributor

@jarydo jarydo commented Oct 17, 2023

Notion Ticket Link

https://www.notion.so/uwblueprintexecs/Add-location-to-users-BE-3282fb1c96e34c70bd01447c33ec911f

Implementation Description

  • Added organization_coordinates field to user, storing latitude and longitude of given address as a GeoPoint (2D array)
  • Utilized Geocode API to find proper coordinates of organization_address and update organization_coordinates field accordingly (triggered when creating a user or updating a user)

Steps To Test

  1. Check that when creating or updating a user, organization_coordinates are appropriately updated based on address

What Should Reviewers Focus On?

  • Confirm creating a user works as intended, I was able to test updating a user through unit tests and GraphQL queries but found it more difficult to test creating a user

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have added tests for my changes
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@jarydo jarydo temporarily deployed to staging October 17, 2023 02:15 — with GitHub Actions Inactive
@jarydo jarydo temporarily deployed to staging October 17, 2023 02:21 — with GitHub Actions Inactive
@shahanneda shahanneda temporarily deployed to staging October 19, 2023 02:02 — with GitHub Actions Inactive
@shahanneda shahanneda temporarily deployed to staging October 19, 2023 02:04 — with GitHub Actions Inactive
Copy link
Contributor

@shahanneda shahanneda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was one slight issue when I tested creating a new user, I fixed it now. Also, in future pr's feel free to add types where you see fit if its helps you! As I was fixing it I found adding some types helped me.

@shahanneda shahanneda temporarily deployed to staging October 19, 2023 04:35 — with GitHub Actions Inactive
@jarydo jarydo merged commit 4114ea7 into main Oct 20, 2023
2 checks passed
@jarydo jarydo deleted the jarydo/add-coordinates-to-user branch October 20, 2023 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants