Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate/Deactivate User By ID #95

Merged
merged 6 commits into from
Oct 12, 2023
Merged

Conversation

jarydo
Copy link
Contributor

@jarydo jarydo commented Oct 12, 2023

Notion Ticket Link

https://www.notion.so/uwblueprintexecs/Dev-e3112e78136f49b4b042e9a0d9df9723?p=0e5458e9d9254c83a2881f33c4e9543c&pm=s

Implementation Description

  • Added active flag to user, set by default to True
  • Created mutations to activate/deactivate user (admins can activate/deactivate anyone, users can deactivate themselves)

Steps To Test

  1. Check that appropriate functionality is working

What Should Reviewers Focus On?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have added tests for my changes
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@jarydo jarydo temporarily deployed to staging October 12, 2023 00:27 — with GitHub Actions Inactive
Copy link
Contributor

@shahanneda shahanneda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done Jaryd, this is great!

Also, another great thing, is since you set the default value of active to be True (and made it not requried), this doesn't break if used with the old MongoDB data (which means you didn't actually have to create a separate DB), and also the other developers won't have to rebase or anything like that once we merge.

@shahanneda shahanneda merged commit f016d52 into main Oct 12, 2023
2 checks passed
@shahanneda shahanneda deleted the jarydo/activate-deactivate-user branch October 12, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants