Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit meal request form #83

Merged
merged 24 commits into from
Aug 6, 2023
Merged

Edit meal request form #83

merged 24 commits into from
Aug 6, 2023

Conversation

sophie-wjyang
Copy link
Contributor

@sophie-wjyang sophie-wjyang commented Jun 7, 2023 •
edited
Loading

Notion Ticket Link

https://www.notion.so/uwblueprintexecs/ASP-Experience-Edit-Meal-Request-Form-UI-a2f2d2946a0c423a8225c1cdcfe49565?pvs=4

Implementation Description

  • created the "edit meal request" form
  • added all UI elements on the mockup

Steps To Test

  1. make sure the implementation matches the design visually
  2. the necessary fields are required

What Should Reviewers Focus On?

  • mostly just that the page visually matches the mockup

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have added tests for my changes
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

shahanneda
shahanneda reviewed Jun 7, 2023
View reviewed changes
Copy link
Contributor

@shahanneda shahanneda left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work you two!! This form looks great!

I left a few small comments, let me know if you have any question!

frontend/src/components/pages/MealRequestForm.tsx Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we rename this file to EditMealRequestForm.tsx?

frontend/src/components/pages/Dashboard.tsx Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should lint before making the PR. Linting should fix easy formatting issues.

You can lint by following the instructions here:
https://github.com/uwblueprint/feeding-canadian-kids#linting--formatting

Mainly run docker exec -it fck_frontend /bin/bash -c "yarn fix" in a seperate terminal.

frontend/src/components/pages/MealRequestForm.tsx Outdated
>
<ModalOverlay />
<ModalContent
maxWidth={{ base: "100px", md: "900px" }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we fix the mobile view? Right now on mobile it is very small on mobile:
image

(You can view the mobile view by using the chrome inspector)

The problem is this 100px here, change this to something bigger. Try 90vw, if that works that is better (vw is relative to the devices width), else just something bigger like "400px" or somethign works as well, experiment with the inspector to see different sizes.

@shahanneda shahanneda temporarily deployed to staging June 13, 2023 23:00 — with GitHub Actions Inactive
@shahanneda shahanneda temporarily deployed to staging June 13, 2023 23:02 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Jun 13, 2023 •
edited
Loading

Visit the preview URL for this PR (updated for commit 0752520):

https://feeding-canadian-kids-staging--pr83-meal-request-form-c9jo8sc1.web.app

(expires Sat, 12 Aug 2023 20:05:08 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f3744353be12c99e3df04fa4e0f28b3ad46bf004

@shahanneda shahanneda temporarily deployed to staging June 13, 2023 23:04 — with GitHub Actions Inactive
@shahanneda shahanneda changed the title Create meal request form Edit meal request form Jul 11, 2023
@sophie-wjyang sophie-wjyang temporarily deployed to staging July 27, 2023 22:45 — with GitHub Actions Inactive
@sophie-wjyang sophie-wjyang temporarily deployed to staging July 28, 2023 00:53 — with GitHub Actions Inactive
@shahanneda shahanneda temporarily deployed to staging August 5, 2023 19:39 — with GitHub Actions Inactive
@shahanneda shahanneda temporarily deployed to staging August 5, 2023 20:00 — with GitHub Actions Inactive
@shahanneda shahanneda temporarily deployed to staging August 5, 2023 20:00 — with GitHub Actions Inactive
@shahanneda shahanneda temporarily deployed to staging August 5, 2023 20:02 — with GitHub Actions Inactive
@shahanneda shahanneda temporarily deployed to staging August 5, 2023 20:02 — with GitHub Actions Inactive
shahanneda
shahanneda approved these changes Aug 6, 2023
View reviewed changes
Copy link
Contributor

@shahanneda shahanneda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I just made some minor cleanups and adjustments, you can check it out here: 7d280fa LMK if you have any questions.

@shahanneda shahanneda merged commit a9a48f4 into main Aug 6, 2023
4 checks passed
@shahanneda shahanneda deleted the meal-request-form branch August 6, 2023 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahanneda shahanneda shahanneda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sophie-wjyang @shahanneda @hannahxdu