Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display dates as a range #175

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Display dates as a range #175

merged 2 commits into from
Sep 24, 2024

Conversation

ColinToft
Copy link
Collaborator

@ColinToft ColinToft commented Sep 22, 2024

Notion Ticket Link

Replace with Ticket URL
Displays dates as a range in:

  1. ASP dashboard
  2. When creating a meal request
  3. Meal donation commitment
  4. Meal donor upcoming donation list
  5. Meal donor completed donation list

@shahanneda see my slack messages for screenshots of these

Steps To Test

  1. Check that all locations that have been changed appear as desired.

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have added tests for my changes
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

Copy link

Visit the preview URL for this PR (updated for commit 30e4e88):

https://feeding-canadian-kids-staging--pr175-display-date-rang-b2dqlrjh.web.app

(expires Sun, 29 Sep 2024 17:42:41 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f3744353be12c99e3df04fa4e0f28b3ad46bf004

Copy link
Contributor

@shahanneda shahanneda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Colin!

@shahanneda shahanneda merged commit 192f4c9 into main Sep 24, 2024
4 checks passed
@shahanneda shahanneda deleted the display-date-ranges branch September 24, 2024 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants