Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve the DateFormatterTest #24

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

improve the DateFormatterTest #24

wants to merge 3 commits into from

Conversation

muellerc
Copy link

I improved the DateFormatter test to work in other TimeZones too (not only in my one ;-) ).

@TomasMorecom
Copy link

Have anyone fixed the broken DateFormatterTest yet? I tried to apply this patch, and it resolved one of the tests but still I get this
Expected: 130101050000000R
Actual: 121231170000000R
:
formatRelativeDate(org.jsmpp.util.DateFormatterTest) Time elapsed: 0.006 sec <<< FAILURE!
java.lang.AssertionError: expected: <13010105000000R> but was: <121231170000000R>
at org.testng.Assert.fail(Assert.java:89)
at org.testng.Assert.failNotEquals(Assert.java:480)
at org.testng.Assert.assertEquals(Assert.java:118)
at org.testng.Assert.assertEquals(Assert.java:171)
at org.testng.Assert.assertEquals(Assert.java:181)
at org.jsmpp.util.DateFormatterTest.formatRelativeDate(DateFormatterTest.java:129)

@dpocock
Copy link

dpocock commented Jan 6, 2015

I've opened a new issue for this opentelecoms-org/jsmpp#1

As described there, both the RelativeTimeFormatter and the unit test appear to be wrong.

@dpocock
Copy link

dpocock commented Jan 6, 2015

Merged here: opentelecoms-org/jsmpp@50ff268

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants