Improve JNI exception handling and logging #691
+531
−436
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MethodID
and made theJObject's
method calls use them for type safety. Updated allJvmWrapper
jni methods.vformat(
).DEV_ASSERT
statements. As we progress toward a stable release, we already removed most of the crashes. I simply finished the last remaining ones. The newDEV_ASSERT
statements are mostly related to JNI errors, which is not the type users should have to care about.LOG_ERROR_WITH_ALERT
is also gone. Since Godot 4.3, errors are automatically displayed in the editor as small popups. It's not necessary to spawn our own alert window anymore.exceptionDescribe()
when set. This handler is now set to be the method of a new singleton wrapper that takes aThrowable
instance and print its stacktrace directly.This is what it looks like when a JVM exception is handled from the C++ side with the new handler: