Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable Editor Plugin. #690

Merged
merged 13 commits into from
Sep 24, 2024
Merged

Reenable Editor Plugin. #690

merged 13 commits into from
Sep 24, 2024

Conversation

CedNaru
Copy link
Member

@CedNaru CedNaru commented Sep 15, 2024

The editor plugin has been disabled since Godot 4 because we didn't have the time to go over it and adapt it to Godot 4.
On top of that, the code was made extremely early when we weren't used to Godot's internal (we only knew the GDNative API before) so we had a lot of aberrations in it.

I removed most of it to keep only the core features:

  • Add a button to build the JVM project using gradle. The result of the build is then displayed in a window.
  • Automatically build the JVM project when the game is about to be run. It displays a window only in case of build error.
  • "About" Dialog, that can optionally be displayed the first time a user open the editor to warn them about the module.

As a new feature, you can also generate the JVM/Gradle project from the editor now.
image
image

For that purpose, I directly encoded the files into a header using a python script. The script has been saved so we can use it whenever the template files need to be updated. Note that there is a new version.h to update, it will automatically replace the version used in the template.

docs/src/doc/getting-started/setting-up.md Outdated Show resolved Hide resolved
src/editor/template/.gitignore.template Outdated Show resolved Hide resolved
@chippmann
Copy link
Contributor

chippmann commented Sep 17, 2024

As a question; could that python script not be executed via scons as part of the build?

@CedNaru
Copy link
Member Author

CedNaru commented Sep 17, 2024

Added template generation directly when building the engine.

src/editor/project/templates.h Outdated Show resolved Hide resolved
@CedNaru CedNaru force-pushed the feature/add_back_editor_plugin branch 4 times, most recently from 8999235 to 37195e4 Compare September 18, 2024 14:32
@CedNaru CedNaru linked an issue Sep 18, 2024 that may be closed by this pull request
@CedNaru CedNaru force-pushed the feature/add_back_editor_plugin branch from 37195e4 to c9c777b Compare September 21, 2024 17:37
Copy link
Contributor

@chippmann chippmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After creating the files from within the godot editor plugin, the gradlew file still needs to be made executable.
We should do this after we created the files

piiertho
piiertho previously approved these changes Sep 23, 2024
@CedNaru CedNaru merged commit 5a29679 into master Sep 24, 2024
50 checks passed
@CedNaru CedNaru deleted the feature/add_back_editor_plugin branch September 24, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor the editor plugin
3 participants