-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reenable Editor Plugin. #690
Conversation
6a9a88f
to
31a861b
Compare
As a question; could that python script not be executed via scons as part of the build? |
Added template generation directly when building the engine. |
8999235
to
37195e4
Compare
37195e4
to
c9c777b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After creating the files from within the godot editor plugin, the gradlew file still needs to be made executable.
We should do this after we created the files
6dcddcf
to
e6f36df
Compare
The editor plugin has been disabled since Godot 4 because we didn't have the time to go over it and adapt it to Godot 4.
On top of that, the code was made extremely early when we weren't used to Godot's internal (we only knew the GDNative API before) so we had a lot of aberrations in it.
I removed most of it to keep only the core features:
As a new feature, you can also generate the JVM/Gradle project from the editor now.
For that purpose, I directly encoded the files into a header using a python script. The script has been saved so we can use it whenever the template files need to be updated. Note that there is a new version.h to update, it will automatically replace the version used in the template.