Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kotlin to 2.0.20 and update other dependencies #662

Merged
merged 3 commits into from
Aug 30, 2024

Conversation

chippmann
Copy link
Contributor

This also prepares the api-gen for a kotlin poet update to the latest version. But because of square/kotlinpoet#1759 the update cannot be performed yet.

@chippmann chippmann force-pushed the feature/update_kotlin branch 2 times, most recently from 0989716 to c43a4b3 Compare August 21, 2024 15:38
This also prepares the api-gen for a kotlin poet update to the latest version. But because of square/kotlinpoet#1759 the update cannot be performed yet.
@piiertho
Copy link
Member

piiertho commented Aug 22, 2024

Can you solve the TODO in here:

//TODO: Use Documentable interface from poet when upgrading kotlin poet.
?

Edit: I did not see kotlin poet is not updated yet.

@CedNaru CedNaru self-requested a review August 22, 2024 23:51
Copy link
Member

@CedNaru CedNaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kotlin 2.0.20 just got released

@chippmann chippmann requested a review from CedNaru August 23, 2024 06:53
@chippmann chippmann changed the title Update kotlin to 2.0.10 and update other dependencies Update kotlin to 2.0.20 and update other dependencies Aug 23, 2024
@piiertho
Copy link
Member

Why tests are failing ?

@chippmann
Copy link
Contributor Author

Why tests are failing ?

Just because of a slow runner. We ran into the test execution time limit of 30 minutes i set a while ago.
Will rerun it

@chippmann chippmann merged commit adc7a0a into master Aug 30, 2024
50 checks passed
@chippmann chippmann deleted the feature/update_kotlin branch August 30, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants