Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Content Generation for Develop Branch #133

Conversation

aj-stein-nist
Copy link
Contributor

@aj-stein-nist aj-stein-nist commented Aug 31, 2022

Committer Notes

This will close #132. I wanted to ensure we share resolved profiles and other content following review and merge of work for #97 and lower burden for our own devs and outside contributors to see the result.

Also related notionally to dev feedback in #120 .

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?

@aj-stein-nist aj-stein-nist self-assigned this Aug 31, 2022
@aj-stein-nist aj-stein-nist linked an issue Aug 31, 2022 that may be closed by this pull request
4 tasks
@aj-stein-nist aj-stein-nist changed the title Update usnistgov/oscal-content#132 to add pipeline content gen for dev. Add Content Generator for Develop Branch Aug 31, 2022
@aj-stein-nist aj-stein-nist changed the title Add Content Generator for Develop Branch Add Content Generation for Develop Branch Aug 31, 2022
@aj-stein-nist
Copy link
Contributor Author

During weekly status review, I agreed to add some more debugging steps to collect state in the workspace for debugging in the event the build breaks or fails. Will do that ASAP for Dave to quickly review today.

@aj-stein-nist
Copy link
Contributor Author

During weekly status review, I agreed to add some more debugging steps to collect state in the workspace for debugging in the event the build breaks or fails. Will do that ASAP for Dave to quickly review today.

Note to AJ for posterity: going to splice content in from aj-stein-nist/oscal-content@b5b1bd9 into the content-artifacts.yaml workflow.

Per feedback from @david-waltermire-nist, we do want to have the work-
space intermediate data sucked up and stored in GH artifacts.
… github.com:aj-stein-nist/oscal-content into 132-auto-generate-content-in-new-development-branch
@aj-stein-nist
Copy link
Contributor Author

Alright @david-waltermire-nist, code added and ready for prompt review. Below is a sample workflow run (it failed, but that is good for this reason) to show the debugging content collected and attached to the run. This shows always() working with sad path, not just happy path.

https://github.com/usnistgov/oscal-content/actions/runs/3024676041

Copy link
Contributor

@david-waltermire david-waltermire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@david-waltermire david-waltermire merged commit d3c227d into usnistgov:main Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-generate Content in New Development Branch
2 participants