Reimplemented error tree disambiguation in Java #2035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Draft
DavyLandman
reviewed
Oct 3, 2024
src/org/rascalmpl/library/lang/rascal/tests/concrete/recovery/ParseErrorDisambiguator.java
Outdated
Show resolved
Hide resolved
src/org/rascalmpl/library/lang/rascal/tests/concrete/recovery/ParseErrorDisambiguator.java
Outdated
Show resolved
Hide resolved
src/org/rascalmpl/library/lang/rascal/tests/concrete/recovery/ParseErrorDisambiguator.java
Outdated
Show resolved
Hide resolved
src/org/rascalmpl/library/lang/rascal/tests/concrete/recovery/ParseErrorDisambiguator.java
Outdated
Show resolved
Hide resolved
src/org/rascalmpl/library/lang/rascal/tests/concrete/recovery/ParseErrorDisambiguator.java
Outdated
Show resolved
Hide resolved
src/org/rascalmpl/library/lang/rascal/tests/concrete/recovery/ParseErrorDisambiguator.java
Outdated
Show resolved
Hide resolved
Also, optimized the case where no changes are detected in subtrees.
DavyLandman
reviewed
Oct 3, 2024
| * possibly without ambiguities. | ||
| */ | ||
|
|
||
| public synchronized IConstructor disambiguateErrors(IConstructor arg, IBool allowAmbiguity) { |
There was a problem hiding this comment.
does not need to by synchronized anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the (naive) error disambiguation filter written in Rascal. The time complexity has been reduced from
O(n^2)toO(n), wherenis the number of nodes in the original parse forest.In practice this means that in extreme scenarios (where there are many ambiguous error trees), the time it takes to disambiguate a parse forest is about the same as the time it takes to parse the input.
For instance, in the
SlowDisambiguationBugtest case included in this PR both the parse time and disambiguation time are around 5 seconds on my machine. Disambiguation in Rascal took +- 30 minutes.