Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(#304) Environments color 🎨 #1053

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feat(#304) Environments color 🎨 #1053

wants to merge 9 commits into from

Conversation

MathieuDreano
Copy link

@MathieuDreano MathieuDreano commented Nov 25, 2023 •
edited
Loading

Description

associated issue: close #304

Associate a color to each environment, for quick visualization (and avoid calling your production environment by mistake...)

normal display
image

environment selection:
image

environment settings
image

env.bru format
image

highlight on request tab
image

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes --> well, I hope so
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

@MathieuDreano MathieuDreano marked this pull request as draft November 25, 2023 17:30
@MathieuDreano MathieuDreano changed the title [WIP] associate colors to environments feat(#304) Environments color Nov 25, 2023
@MathieuDreano MathieuDreano mentioned this pull request Nov 25, 2023
Open
@MathieuDreano MathieuDreano marked this pull request as ready for review November 26, 2023 19:45
@edbrannin
Copy link
Contributor

It would be nice if this could tint more than just the Environment button in the corner, but that's probably best left as a follow-up.

(Also, why all the force-pushes?)

@MathieuDreano MathieuDreano marked this pull request as draft November 28, 2023 09:37
@aphexcx
Copy link

aphexcx commented Feb 9, 2024

Hi! When will this be merged? This one feature is the only thing stopping us from moving from Insomnia to Bruno LOL

@MathieuDreano MathieuDreano marked this pull request as ready for review February 15, 2024 09:02
@MathieuDreano
Copy link
Author

quite some changes, using redux store.
I think it's ready, feel free to try it out. I personally use it in my daily job.

@MathieuDreano
Copy link
Author

As requested, added visual aid on request tab
image

@MathieuDreano MathieuDreano changed the title feat(#304) Environments color feat(#304) Environments color 🔴🔵🟡 Feb 15, 2024
@MathieuDreano MathieuDreano changed the title feat(#304) Environments color 🔴🔵🟡 feat(#304) Environments color 🎨 Feb 15, 2024
@aphexcx
Copy link

aphexcx commented Mar 12, 2024

Following up on this, really appreciate seeing the progress:)

@aphexcx
Copy link

aphexcx commented Mar 21, 2024

Checking in again:)

@aphexcx
Copy link

aphexcx commented Apr 11, 2024

Friendly ping:)

@bobzomer
Copy link

bobzomer commented May 8, 2024

Friendly ping:)

I would also love it to see it merged and available in my beloved bruno!

@sanjai0py sanjai0py self-assigned this May 8, 2024
@aphexcx
Copy link

aphexcx commented May 30, 2024

Beep 🤖

@florianlacreuse
Copy link

Any updates on this PR? It would be nice to have it in Bruno. Thanks!

@aeris
Copy link

aeris commented Jul 24, 2024

If something interested, I rebase this PR on v1.23.0
https://git.imirhil.fr/aeris/bruno/src/branch/feature/environment-color

@MathieuDreano
Copy link
Author

MathieuDreano commented Jul 24, 2024 •
edited
Loading

Hello there, I rebased the work onto main branch. (not something I will do every month, fixing conflicts..)

@peterkeppert-anasoft
Copy link

Hello, could somebody from Bruno maintainers please indicate what is the expected timeframe of this feature's integration or what are the next steps with this pull request?

Certainly for our team (and I believe many others) used to Insomnia's environment colors, this represents a significant and eagerly awaited UX improvement. Thanks!

@SZubarev
Copy link

Any updates on this feature?

@helloanoop helloanoop assigned helloanoop and unassigned sanjai0py Sep 23, 2024
@MathieuDreano
associate environment to a color
b3e481f 
Signed-off-by: mathieu <[email protected]>

use StyledWrapper

Signed-off-by: mathieu <[email protected]>

don't save anything for color if it is not set

Signed-off-by: mathieu <[email protected]>

use redux store instead of local state

remove logs

fix selectedEnvironment

cleanup

add bottom border on active tab
@MathieuDreano
associate environment to a color
aec0696 
Signed-off-by: mathieu <[email protected]>
@MathieuDreano
fix error during mergeconflict
70349b1 
Signed-off-by: mathieu <[email protected]>
@MathieuDreano
move dependency to appropriate package.json
bc85bc5 
Signed-off-by: mathieu <[email protected]>
@MathieuDreano
remove unused code
2beec87 
Signed-off-by: mathieu <[email protected]>
@MathieuDreano
use border instead of background color
d1edc8e 
Signed-off-by: mathieu <[email protected]>
@MathieuDreano
simplify onColorChange
1ce499f 
Signed-off-by: mathieu <[email protected]>
@MathieuDreano
add black, keep backgound on unselected color
d863c54 
Signed-off-by: mathieu <[email protected]>
@MathieuDreano
fix conflicts
1a60d77 
Signed-off-by: mathieu <[email protected]>
@MathieuDreano
Copy link
Author

Hello there, I rebased the branch on master andfixed the conflicts

Also, I changed to a border instead of full background (to match both dark and light mode)
And some codefix for maintainability.
I feel like the color could be used elsewhere to emphasis the environment, but let's keep this feature simple for now.

I still hope this will get released someday (I see the number of PR decreasing, that's a good trend)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdreano mdreano mdreano approved these changes

Assignees

@helloanoop helloanoop

Labels
long-term-goal pr-feature size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature request: colored environments