Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Dockerfile to build again #1593

Merged

Conversation

Mr0grog
Copy link
Collaborator

@Mr0grog Mr0grog commented Oct 19, 2023

The changes in #1591 caused the CI pipeline to try and build a new release (even if it doesn’t deploy anymore), but it turns out that the passage of time has broken our Dockerfile. Specifically, the first thing the Dockerfile does is try and update NPM to the latest version (usually a good practice), but the latest NPM is no longer compatible with the version of Node.js that the Dockerfile uses.

Since this project is effectively shut down and not actively maintained, I went ahead and removed the step that updates NPM so this won't happen again. For good measure, I also updated the base image to the latest Node.js 18.x release just in case.

This supersedes #1592.

Update the base version of Node.js to the latest 18.x release and stop updating NPM as the first step in the build. This fixes an issue where the version of Node.js we were using wasn't compatible with the latest NPM, and which broke builds.
@Mr0grog Mr0grog merged commit 86d41b1 into main Oct 19, 2023
1 check passed
@Mr0grog Mr0grog deleted the all-things-rot-in-due-time-but-all-things-can-also-be-repaired branch October 19, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant