Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vote-2841: Hover style fix - NVRF Links #989

Merged
merged 6 commits into from
Sep 24, 2024

Conversation

clmedders
Copy link
Contributor

@clmedders clmedders commented Sep 16, 2024

Jira ticket

Vote-2841

Description

Addressing a hover style for links within the NVRF app. When links were active there was no contrast between the background and text color

Solution Updated the USWDS override file for usa-form and used the same styles from other link hover effects

Before and After:
Screenshot 2024-09-16 at 3 34 39 PM

Deployment and testing

Post-deploy steps

  1. cd into the votegov theme and run npm run build

QA/Testing instructions

  1. Start up local and visit a state page and start the digital form
  2. Fill out form and go to the last page for delivery and scroll to the section A few important notes and both links type of identification and guide to voting.
  3. click on the links or use your dom and turn on :active state and verity that the correct styles are being applied

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@clmedders clmedders marked this pull request as ready for review September 16, 2024 19:56
@rayestrada rayestrada merged commit e4285d8 into dev Sep 24, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/vote-2841-nvrf-link-hover branch September 25, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants