Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vote-2840: English String Update #984

Merged
merged 3 commits into from
Sep 23, 2024
Merged

Conversation

clmedders
Copy link
Contributor

@clmedders clmedders commented Sep 13, 2024

Jira ticket

Vote-2840

Description

Updating English string to add online to address translation bug

Deployment and testing

Post-deploy steps

  1. lando retune

QA/Testing instructions

  1. review file changes and confirm that online had been added to the end of the string
  2. visit a state page and verify that translation are happening for this string

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@clmedders clmedders changed the title Bug/vote 2840 english string update Vote-2840: English String Update Sep 13, 2024
@clmedders clmedders marked this pull request as ready for review September 13, 2024 16:58
@mlloydbixal mlloydbixal self-requested a review September 16, 2024 19:15
@rayestrada rayestrada merged commit b05998d into dev Sep 23, 2024
3 checks passed
@rayestrada rayestrada deleted the bug/vote-2840-english-string-update branch September 25, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants