Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore failing when CVE scanner finds a vulnerability #167

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

WyriHaximus
Copy link
Member

@WyriHaximus WyriHaximus commented Feb 20, 2021

During the migration to GitHub Actions in #160 this functionality
was mistakenly and overzealously removed. Since PHP 8 and
Alpine 3.13 are out and #166 has been filed, currently with a CVE
for musl in it, this check should have failed as it is our goal
to ship images without known CVE's in it. On my own PHP images
the CVE checking fails and as such I was surprised that #166
didn't have any failures. Up on checking the CI logs it showed
the musl CVE but the step didn't fail.

This commit restores the original functionality and will make the
CI once again fail when it finds a CVE in one of the images.

Usabilla PHP Docker Template

Reviewers: @usabilla/oss-docker

Type

Please specify the type of changes being proposed:

Q A
Documentation? no
Dockerfile change? no
Build feature? no
Apply CVE Patch? no
Remove CVE Patch? no

@WyriHaximus WyriHaximus added Bug Something isn't working CI This issue or pull request is related to the build process labels Feb 20, 2021
@WyriHaximus WyriHaximus force-pushed the fail-on-failing-cve-scan branch 6 times, most recently from dc378e3 to 8176245 Compare February 20, 2021 22:42
Copy link
Member

@rdohms rdohms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we go back a step and explain:
A. the problem, B. Why this is the solution?

@WyriHaximus WyriHaximus changed the title Fail on failing CVE scan Restore failing when CVE scanner finds a vulnerability Feb 22, 2021
@vox-eve vox-eve requested a review from rdohms February 22, 2021 17:17
@WyriHaximus
Copy link
Member Author

@rdohms Updated PR commit message and description

Makefile Show resolved Hide resolved
Makefile Show resolved Hide resolved
Copy link
Contributor

@agustingomes agustingomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally looks ok, but with the failing pipeline right now will be tricky to get this merged.

@WyriHaximus
Copy link
Member Author

generally looks ok, but with the failing pipeline right now will be tricky to get this merged.

@agustingomes So it fails because it finds a CVE in the nginx 1.16 image for nginx ;)

@cvmiert
Copy link
Contributor

cvmiert commented Feb 23, 2021

generally looks ok, but with the failing pipeline right now will be tricky to get this merged.

@agustingomes So it fails because it finds a CVE in the nginx 1.16 image for nginx ;)

🤔 How will you be able to merge it in?

@WyriHaximus
Copy link
Member Author

generally looks ok, but with the failing pipeline right now will be tricky to get this merged.

@agustingomes So it fails because it finds a CVE in the nginx 1.16 image for nginx ;)

How will you be able to merge it in?

That's the question! Can either fix that vurn in this PR, or fix it in a separate PR and then rebase

During the migration to GitHub Actions in #160 this functionality
was mistakenly and overzealously removed. Since PHP 8 and
Alpine 3.13 are out and #166 has been filed, currently with a CVE
for musl in it, this check should have failed as it is our goal
to ship images without known CVE's in it. On my own PHP images
the CVE checking fails and as such I was surprised that #166
didn't have any failures. Up on checking the CI logs it showed
the musl CVE but the step didn't fail.

This commit restores the original functionality and will make the
CI once again fail when it finds a CVE in one of the images.
@frankkoornstra frankkoornstra removed their request for review March 19, 2021 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working CI This issue or pull request is related to the build process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants