build: upgrade gmp to 6.3.0 #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The advent of the zig build system on edge introduced a bug on
macos-aarch64and possiblylinux-aarch64as well. This bug presented as random loom corruption after heavy workloads such as booting from a pill or recompiling arvo several times. The root cause ended up being buggy assembly in GMP 6.2.1. We had disabled assembly altogether formacos-aarch64in Bazel:vere/bazel/third_party/gmp/gmp.BUILD
Lines 22 to 23 in be3b042
The buggy assembly can be reproduced in isolation by downloading GMP 6.2.1 on a
macos-aarch64machine, running./configure --disable-share --with-pic, and then runningmake checkand looking at all the failing tests. This issue has been fixed in 6.3.0 and the random loom corruption does not happen with these changes.cc @ripperi