Merge develop to next/kelvin/410 #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same as urbit/urbit#3261 but for vere. From what I can tell this NAT-PMP stuff is fairly well supported by routers, works on my machine at least.
This reverts commit a37f052.
…orrect format specifier
CTRL+z to force kill an urbit process has been broken for some time. This was caused by our SIGTSTP handler being overwritten in `_cw_play_imp` that gets called not only during replay but on every boot if we're not a new pier.
Adds `--lmdb-map-size` to specify LMDB's initial memory mapping size, intended for use by users who need a size smaller than our default of 500G. Note: `case 12` to avoid collision with the other arg added in #654.
Solves #660 Prevents Nock 9 from crashing the pier if the axis argument is a cell. Without the check Vere may call `u3qc_cap` on a cell, leading to a segfault or an assertion failure: ``` Assertion '_(u3a_is_atom(b))' failed in pkg/noun/retrieve.c:1011 ``` To reproduce the bug, run in Dojo: ``` .*(0 [9 [2 2] 0 1]) ``` Is there a way to add a unit test to guard against a downgrade?
This PR: 1. Adds the `--serf-bin` option for specifying a serf executable 2. Sets `u3_Host.wrk_c` to `--serf-bin`'s value if specified, self otherwise 3. Performs boot's replay in a subprocess that spawns our own serf (by default) or the specified serf if provided 4. Spawns a thread in `_cw_play` that exits if it reads `EOF` from `STDIN` (thereby ensuring the child process for replaying events exits whenever the parent is killed) These changes allow Ares (or any other runtime) to implement its own `play` subcommand and have Vere use it for the boot process's replay functionality. Tests: - [x] `linux-x86_64` subcommand, replay via boot, killing king via INT, KILL, TERM - [x] `macos-aarch64` subcommand, replay via boot, killing king via INT, KILL, TERM
This PR fixes an issue introduced in #654, whereby docked binaries could not replay.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.