Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to OpenStudio 3.8 & Ruby 3.2 #59

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open
5 changes: 3 additions & 2 deletions .github/workflows/nightly_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ name: Core-gem CI

on:
# push:
workflow_dispatch:
schedule:
# https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#schedule
# 5 am UTC (11pm MDT the day before) every weekday night in MDT
Expand All @@ -18,11 +19,11 @@ jobs:
weeknight-tests:
runs-on: ubuntu-latest
container:
image: docker://nrel/openstudio:3.7.0
image: docker://nrel/openstudio:3.8.0
steps:
- uses: actions/checkout@v4
- name: Update gems
run: bundle update
run: bundle install
- name: Run Rspec
run: bundle exec rspec
# coveralls action docs: https://github.com/marketplace/actions/coveralls-github-action
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ Gemfile.lock
/gems
/_yardoc/
/coverage/
.coverage
/doc/
/pkg/
/spec/reports/
Expand Down
6 changes: 4 additions & 2 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,12 @@ gemspec
# checkout the latest version (develop) from github.
allow_local = ENV['FAVOR_LOCAL_GEMS']

gem 'regexp_parser', '2.9.0'
# 2.9.1 breaks test_with_openstudio, for more information: https://github.com/NREL/OpenStudio/issues/5203
# pin this dependency to avoid unicode_normalize error
gem 'addressable', '2.8.1'
gem 'addressable', '2.8.1' # openstudio:test_with_openstudio
# pin this dependency to avoid using racc dependency (which has native extensions)
gem 'parser', '3.2.2.2'
# gem 'parser', '3.2.2.2'

# if allow_local && File.exist?('../OpenStudio-extension-gem')
# gem 'openstudio-extension', path: '../OpenStudio-extension-gem'
Expand Down
2 changes: 1 addition & 1 deletion lib/urbanopt/core/version.rb
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@

module URBANopt
module Core
VERSION = '0.11.0'.freeze
VERSION = '0.12.0'.freeze
end
end
15 changes: 8 additions & 7 deletions urbanopt-core-gem.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,14 @@ Gem::Specification.new do |spec|
spec.bindir = 'exe'
spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
spec.require_paths = ['lib']
spec.required_ruby_version = '~> 2.7.0'
# We support exactly Ruby v3.2.2 because os-extension requires bundler==2.4.10 and that requires Ruby 3.2.2: https://stdgems.org/bundler/
# It would be nice to be able to use newer patches of Ruby 3.2, which would require os-extension to relax its dependency on bundler.
spec.required_ruby_version = '3.2.2'

spec.add_development_dependency 'bundler', '~> 2.1'
spec.add_development_dependency 'rake', '~> 13.0'
spec.add_development_dependency 'rspec', '~> 3.9'
spec.add_development_dependency 'simplecov', '~> 0.18.2'
spec.add_development_dependency 'simplecov-lcov', '~> 0.8.0'
spec.add_development_dependency 'rspec', '~> 3.13'
spec.add_development_dependency 'rubocop', '1.50'
spec.add_development_dependency 'simplecov', '0.22.0'
spec.add_development_dependency 'simplecov-lcov', '0.8.0'

spec.add_dependency 'openstudio-extension', '~> 0.7.1'
spec.add_dependency 'openstudio-extension', '~> 0.8.1'
end