-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade OpenModelica #641
Open
vtnate
wants to merge
8
commits into
develop
Choose a base branch
from
bump-om
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Upgrade OpenModelica #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests failing? should I wait until that gets resolved to review? |
No, please review now. The tests are failing because in modelica_runner.py I'm referring to an image that doesn't exist yet. Will you please:
Once those are good, I can re-run CI and once we have all green you can approve and we can merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any background context you want to provide?
A new version of OpenModelica was recently released. We can now take advantage of their "many improvements and bug fixes" in this newest version.
What does this PR accomplish?
cmake
to a different part of the Dockerfile to be as similar as possible to the OM Dockerfile ours is modeled onHow should this be manually tested?
2.1.0
3.0.0
(@nllong is that the right version for this change?)What are the relevant tickets?
Screenshots (if appropriate)