Fix inconsistency for results associated to skipped blocks

uphold · Aug 3, 2024 · 966c2f3 · 966c2f3
1 parent 10dec0a
commit 966c2f3
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 2 deletions.
diff --git a/src/parser/security.js b/src/parser/security.js
@@ -57,7 +57,7 @@ export const parseSecurity = (operation, spec, securityHandlers) => {
       const blockHasMissingValues = Object.keys(block).some(name => readSchemeValue(name) == null);
 
       if (blockHasMissingValues) {
-        report.push({ schemes: {}, status: 'skipped' });
+        report.push({ ok: false, schemes: {} });
         continue;
       }
 

diff --git a/src/parser/security.test.js b/src/parser/security.test.js
@@ -364,12 +364,29 @@ describe('parseSecurity()', () => {
 
     const onRequest = parseSecurity(operation, spec, securityHandlers);
 
-    expect.assertions(2);
+    expect.assertions(3);
 
     await onRequest(request);
 
     expect(securityHandlers.ApiKey).not.toHaveBeenCalled();
     expect(securityHandlers.OAuth2).toHaveBeenCalledTimes(1);
+    expect(request[DECORATOR_NAME].securityReport).toMatchInlineSnapshot(`
+      [
+        {
+          "ok": false,
+          "schemes": {},
+        },
+        {
+          "ok": true,
+          "schemes": {
+            "OAuth2": {
+              "data": "OAuth2 data",
+              "ok": true,
+            },
+          },
+        },
+      ]
+    `);
   });
 
   it('should validate scopes', async () => {