fix(codegen): Adjust mvvm toolkit properties discovery #18326

jeromelaban · 2024-09-27T19:13:17Z

GitHub Issue (If applicable): closes #18320

PR Type

What kind of change does this PR introduce?

Bugfix

What is the new behavior?

Restores third party properties types discovery.

PR Checklist

Please check if your PR fulfills the following requirements:

Docs have been added/updated which fit documentation template (for bug fixes / features)
Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
Validated PR Screenshots Compare Test Run results.
Contains NO breaking changes
Associated with an issue (GitHub or internal) and uses the automatic close keywords.
Commits must be following the Conventional Commits specification.

Other information

Internal Issue (If applicable):

jeromelaban · 2024-09-27T19:13:26Z

@Mergifyio backport release/stable/5.4

mergify · 2024-09-27T19:13:29Z

backport release/stable/5.4

✅ Backports have been created

#18334 fix(codegen): Adjust mvvm toolkit properties discovery (backport #18326) has been created for branch release/stable/5.4

unodevops · 2024-09-27T19:51:13Z

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18326/index.html

unodevops · 2024-09-27T19:54:25Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18326/index.html

...eGenerators.Tests/XamlCodeGeneratorTests/Out/WBOP/XamlCodeGenerator_GlobalStaticResources.cs

...Generators.Tests/XamlCodeGeneratorTests/Out/WNBOP/XamlCodeGenerator_GlobalStaticResources.cs

jeromelaban · 2024-09-28T03:58:31Z

/azp run

azure-pipelines · 2024-09-28T03:58:54Z

Azure Pipelines successfully started running 2 pipeline(s).

nventive-devops · 2024-09-28T07:48:01Z

The build 141571 found UI Test snapshots differences: android-28-net8: 23, android-28-net8-Snap: 55, ios: 9, ios-Snap: 43, skia-gtk-screenshots: 1907, skia-linux-screenshots: 1759, skia-windows-screenshots: 1508, wasm: 230, wasm-automated-net9.0-UWP-Default-automated: 56, wasm-automated-net9.0-UWP-RuntimeTests-0: 0, wasm-automated-net9.0-UWP-RuntimeTests-1: 0, wasm-automated-net9.0-UWP-RuntimeTests-2: 0, wasm-automated-net9.0-WinUI-Benchmarks-automated: 0, wasm-automated-net9.0-WinUI-RuntimeTests-0: 0, wasm-automated-net9.0-WinUI-RuntimeTests-1: 0, wasm-automated-net9.0-WinUI-RuntimeTests-2: 0

Details

android-28-net8: 23 changed over 829
🚨🚨 Comparison Details (first 20) 🚨🚨
- CommandBar_LongTitle_Validation_Uno_UI_Samples_Content_UITests_CommandBar_CommandBar_LongTitle
- Detereminate_ProgressRing_Validation50_[#FF0000_#008000_#008000_#FF0000]_Progress-Ring-Value-50
- ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
- ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- SelectionTest_UITests_Microsoft_UI_Xaml_Controls_RadioButtonsTests_RadioButtonsPage
- When_MultipleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- When_SingleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- CommandBar_LongTitle_Validation_CommandBar_-_LongTitle_-_1_-_Initial_State
- CommandBar_LongTitle_Validation_CommandBar_-_LongTitle_-_2_-_Orientation_Landscape
- DecimalFormatterTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
- NativeCommandBar_Size_Uno_UI_Samples_Content_UITests_CommandBar_CommandBar_Dynamic
- NavigateBackAndForthBetweenMenuItemsAndSettings_Fluent_SamplesApp_Samples_Microsoft_UI_Xaml_Controls_NavigationViewTests_FluentStyle_FluentStyle_NavigationViewSample
- UpDownTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
- When_Parent_PointerMoved_After_drag_on_non-scrolling_ScrollViewer
- Detereminate_ProgressRing_Validation75_[#FF0000_#008000_#008000_#008000]_Progress-Ring-Value-75
- ImageStretch_None_Uno_UI_Samples_UITests_ImageTestsControl_Image_Stretch_None
- ListView_ListViewWithHeader_InitializesTest_SamplesApp_Windows_UI_Xaml_Controls_ListView_HorizontalListViewGrouped
- When_NoSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- When_NoSelection_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
android-28-net8-Snap: 55 changed over 1066
🚨🚨 Comparison Details (first 20) 🚨🚨
- MUX_NumberBox_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
- Gesture_Recognizer_Pointer_Events_test_bench_UITests_Shared_Windows_UI_Input_GestureRecognizer_PointersEvents
- Icons_UITests_Shared_Windows_UI_Xaml_Controls_BitmapIconTests_BitmapIcon_Foreground_UITests_Shared_Windows_UI_Xaml_Controls_BitmapIconTests_BitmapIcon_Foreground
- ListView_HorizontalListView_Templates_SamplesApp_Windows_UI_Xaml_Controls_ListView_HorizontalListView_Templates
- Slider_Slider_Frequency_Uno_UI_Samples_Content_UITests_Slider_Slider_Frequency
- Slider_Slider_Inside_ListViewHeader_Uno_UI_Samples_Content_UITests_Slider_Slider_Inside_ListViewHeader
- ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
- Slider_Slider_Inside_ScrollViewer_Uno_UI_Samples_Content_UITests_Slider_Slider_Inside_ScrollViewer
- Image_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_Basic_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_Basic
- ListView_ListView_TransformsOnList_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_TransformsOnList
- NavigationView_MUXControlsTestApp_NavigationViewCustomThemeResourcesPage_MUXControlsTestApp_NavigationViewCustomThemeResourcesPage
- MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal
- TeachingTip_UITests_Microsoft_UI_Xaml_Controls_TeachingTipTests_TeachingTipPage_UITests_Microsoft_UI_Xaml_Controls_TeachingTipTests_TeachingTipPage
- WebView_WebView2_NavigateToUri_SamplesApp_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2_NavigateToUri
- WebView_WebView2_WithHeaders_SamplesApp_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2_WithHeaders
- NavigationView_MUXControlsTestApp_NavigationViewTopNavOnlyPage_MUXControlsTestApp_NavigationViewTopNavOnlyPage
- NavigationView_MUXControlsTestApp_NavigationViewTopNavPage_MUXControlsTestApp_NavigationViewTopNavPage
- MUX_UITests_Shared_Microsoft_UI_Xaml_Controls_TreeViewTests_TreeViewPage_UITests_Shared_Microsoft_UI_Xaml_Controls_TreeViewTests_TreeViewPage
- Pickers_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming
- Scrolling_MUXControlsTestApp_ScrollViewWithScrollControllersPage_MUXControlsTestApp_ScrollViewWithScrollControllersPage
ios: 9 changed over 267
🚨🚨 Comparison Details (first 20) 🚨🚨
- When_SingleSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- When_SingleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- Check_ListView_Swallows_Measure_after_scroll
- ListView_ListViewWithHeader_InitializesTest_SamplesApp_Windows_UI_Xaml_Controls_ListView_HorizontalListViewGrouped
- TextBox_UpdatedBinding_On_OneWay_Mode_UITests_Windows_UI_Xaml_Controls_TextBox_TextBox_Bindings
- ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- ImageStretch_None_Uno_UI_Samples_UITests_ImageTestsControl_Image_Stretch_None
- When_NoSelection_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
ios-Snap: 43 changed over 1057
🚨🚨 Comparison Details (first 20) 🚨🚨
- Brushes_GenericApp_Views_Content_UITests_ImageBrushTestControl_BorderImageBrushRelativeTransform_GenericApp_Views_Content_UITests_ImageBrushTestControl_BorderImageBrushRelativeTransform
- Brushes_ImageBrushWithRotateTransform_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushWithRotateTransform
- Icons_UITests_Shared_Windows_UI_Xaml_Controls_BitmapIconTests_BitmapIcon_Foreground_UITests_Shared_Windows_UI_Xaml_Controls_BitmapIconTests_BitmapIcon_Foreground
- Image_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Vertical_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Vertical
- Image_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Alignment_SizeOnControl_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Alignment_SizeOnControl
- Brushes_BorderImageBrush_Uno_UI_Samples_UITests_ImageBrushTestControl_BorderImageBrush
- NavigationView_MUXControlsTestApp_PaneLayoutTestPage_MUXControlsTestApp_PaneLayoutTestPage
- TextBlock_TextBoxSizeChanging_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBoxSizeChanging
- Icons_UITests_Microsoft_UI_Xaml_Controls_ImageIconTests_ImageIconPage_UITests_Microsoft_UI_Xaml_Controls_ImageIconTests_ImageIconPage
- Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Smaller_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Smaller
- Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Taller_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Taller
- Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Wider_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Wider
- Image_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Formats_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Formats
- ListView_ListViewGroupedChanging_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewGroupedChanging
- ListView_ListView_Image_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Image
- ColorPicker_ColorPickerSample_UITests_Microsoft_UI_Xaml_Controls_ColorPickerTests_ColorPickerSample
- ColorPicker_WinUIColorPickerPage_UITests_Shared_Microsoft_UI_Xaml_Controls_ColorPickerTests_WinUIColorPickerPage
- SwipeControl_MUXControlsTestApp_SwipeControlPage2_MUXControlsTestApp_SwipeControlPage2
- Brushes_ImageBrushStretch_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushStretch
- ListView_ListViewHeaderFooter_ImplicitlyBinded_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewHeaderFooter_ImplicitlyBinded
skia-gtk-screenshots: 1907 changed over 2218
🚨🚨 Comparison Details (first 20) 🚨🚨
- BorderBottomwithmargins.png
- AnimatedIconPage.png
- ApplicationViewSizing.png
- Border_Simple_No_Background_With_Content_Border_With_Background.png
- Button_UseUWPDefaultStyles.png-dark
- CameraCaptureUISample.png
- AutoSuggestBox_BitmapIcon.png-dark
- Clipping652.png-dark
- BitmapIcon_Monochromatic.png-dark
- BorderImageBrushRelativeTransform.png
- ComboBox_Stretch.png-dark
- BorderVersusPanelClipping.png-dark
- ComboBox_Stretch.png
- BorderVersusPanelClipping.png
- ContentControl_NoTemplateDataContext.png
- Border_CornerRadius_with_Opacity.png
- ContentControl_UnsetContent.png-dark
- Border_Simple_No_Background_With_Content_Border_With_Background.png-dark
- DoubleAnimationTestsControl.png-dark
- Button_Inside_Border.png
skia-linux-screenshots: 1759 changed over 2218
🚨🚨 Comparison Details (first 20) 🚨🚨
- AppBarToggleButtonTest.png-dark
- AndroidWindowInsets.png-dark
- AppBar_KeyBoard.png
- AnimatedIconPage.png-dark
- ApplicationViewSizing.png-dark
- AppBarButtonTest.png-dark
- ApplicationViewSpanningRectsPage.png
- AppBarButtonWithIconTest.png-dark
- AppWindowClosing.png
- AppBarToggleButtonTest.png
- ArcSegment.png-dark
- ApplicationViewMode.png-dark
- ArcSegment.png
- ApplicationViewSizing.png
- AuthenticationBroker_Demo.png-dark
- Application_Window lifecycle events.png-dark
- AutoBorderStretchwithtopmargin.png
- AppWindowPositionAndSize.png-dark
- AutomationProperties_AutomationId.png-dark
- AppWindowPositionAndSize.png
skia-windows-screenshots: 1508 changed over 2218
🚨🚨 Comparison Details (first 20) 🚨🚨
- AppBar_KeyBoard.png-dark
- Application_Window lifecycle events.png
- Attributed_text_Simple.png-dark
- Attributed_text_Supserscript.png-dark
- AutoBorderStretchwithleftmargin.png
- AutoSuggestBox_BitmapIcon.png-dark
- BackGesture.png-dark
- BackGesture.png
- Basics.png-dark
- BitmapIcon_Generic.png-dark
- BitmapIcon_Generic.png
- BorderRightwithmargins.png
- BorderTopwithmargins.png-dark
- Border_CornerRadius.png-dark
- Border_Corner_Overlap.png-dark
- Border_With_Off_Centre_ScaleTransform.png
- Border_With_RotateTransform.png-dark
- Button_Inside_Border.png-dark
- Button_IsEnabled_Automated.png-dark
- CheckBox_Button_UWA_Style.png
wasm: 230 changed over 1044
🚨🚨 Comparison Details (first 20) 🚨🚨
- GenericApp.Views.Content.UITests.ContentControlTestsControl.ContentControl_UnsetContent
- GenericApp.Views.Samples.Shared.Content.UITests.GridViewMultipleSelectionMode
- nVentive.Umbrella.Views.UI.Samples.Content.UITests.ButtonTestsControl.Hyperlink_Disabled
- SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewScrollIntoViewSnapPoints
- SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewSelectedItems
- SamplesApp.Windows_UI_Xaml_Controls.ListView.ListView_WithScrollViewer
- UITests.Shared.Windows_UI_Input.GestureRecognizerTests.GestureEventsCommons
- UITests.Shared.Windows_UI_Xaml_Controls.Button.Button_UseUWPDefaultStyles
- UITests.Shared.Windows_UI_Xaml_Controls.Button.Overlapped_Buttons
- UITests.Shared.Windows_UI_Xaml_Controls.Button.RadioButton_Pressed
- UITests.Windows_UI_Input.PointersTests.HitTest_Image
- UITests.Windows_UI_Xaml_Controls.ComboBox.ComboBox_Dropdown_Background_4418
- UITests.Windows_UI_Xaml_Controls.ComboBox.ComboBox_ToggleDisabled
- UITests.Windows_UI_Xaml_Controls.ListView.ListViewItem_Click_Focus
- UITests.Windows_UI_Xaml_Controls.ListView.ListViewTemplateRootIsContainer
- UITests.Windows_UI_Xaml_Controls.ListView.ListView_DisplayMemberPath
- SamplesApp.Windows_UI_Xaml.Clipping.Transform_Ellipse_In_Canvas_in_Two_Grids
- SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewVariableHeightButton
- UITests.Shared.Windows_UI_Input.VisualStatesTests.GridViewItem
- UITests.Shared.Windows_UI_Input.VisualStatesTests.ListViewItem
wasm-automated-net9.0-UWP-Default-automated: 56 changed over 1946
🚨🚨 Comparison Details (first 20) 🚨🚨
- ComboBox_ComboBox_ComboBoxItem_Selection_UITests_Shared_Windows_UI_Xaml_Controls_ComboBox_ComboBox_ComboBoxItem_Selection
- ComboBox_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ComboBox_ComboBox_Header_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ComboBox_ComboBox_Header
- Focus_UITests_Windows_UI_Xaml_FocusTests_Focus_FocusState_UITests_Windows_UI_Xaml_FocusTests_Focus_FocusState
- ComboBox_ComboBox_SelectedIndex_UITests_Shared_Windows_UI_Xaml_Controls_ComboBox_ComboBox_SelectedIndex
- ComboBox_ComboBox_NoDataContext_UITests_Shared_Windows_UI_Xaml_Controls_ComboBox_ComboBox_NoDataContext
- ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
- ComboBox_ComboBox_ToggleDisabled_UITests_Windows_UI_Xaml_Controls_ComboBox_ComboBox_ToggleDisabled
- ComboBox_ComboBox_With_ItemContainerStyle_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ComboBox_ComboBox_With_ItemContainerStyle
- Automation_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name
- Default_StrokeThickness_MyEllipse
- ComboBox_ComboBox_Disabled_UITests_Windows_UI_Xaml_Controls_ComboBox_ComboBox_Disabled
- Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected
- Expander_WinUIExpanderPage_UITests_Shared_Microsoft_UI_Xaml_Controls_ExpanderTests_WinUIExpanderPage
- Focus_UITests_Windows_UI_Xaml_FocusTests_Focus_VisualStates_UITests_Windows_UI_Xaml_FocusTests_Focus_VisualStates
- Focus_Uno_UI_Samples_Content_UITests_FocusTests_FocusManager_FocusDirection_Uno_UI_Samples_Content_UITests_FocusTests_FocusManager_FocusDirection
- ListView_ListView_With_ListViews_Count_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_Measure
- ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
- Default_StrokeThickness_MyPath
- Default_StrokeThickness_MyPath_0_StrokeThickness
- ListView_ListViewHeaderImage_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewHeaderImage
wasm-automated-net9.0-UWP-RuntimeTests-0: 0 changed over 1
wasm-automated-net9.0-UWP-RuntimeTests-1: 0 changed over 1
wasm-automated-net9.0-UWP-RuntimeTests-2: 0 changed over 1
wasm-automated-net9.0-WinUI-Benchmarks-automated: 0 changed over 1
wasm-automated-net9.0-WinUI-RuntimeTests-0: 0 changed over 1
wasm-automated-net9.0-WinUI-RuntimeTests-1: 0 changed over 1
wasm-automated-net9.0-WinUI-RuntimeTests-2: 0 changed over 1

nventive-devops · 2024-09-29T07:14:06Z

The build 141600 found UI Test snapshots differences: android-28-net8: 32, android-28-net8-Snap: 52, ios: 4, ios-Snap: 53, skia-gtk-screenshots: 1798, skia-linux-screenshots: 1817, skia-windows-screenshots: 1508, wasm: 190, wasm-automated-net9.0-UWP-Default-automated: 41, wasm-automated-net9.0-UWP-RuntimeTests-0: 0, wasm-automated-net9.0-UWP-RuntimeTests-1: 0, wasm-automated-net9.0-UWP-RuntimeTests-2: 0, wasm-automated-net9.0-WinUI-Benchmarks-automated: 0, wasm-automated-net9.0-WinUI-RuntimeTests-0: 0, wasm-automated-net9.0-WinUI-RuntimeTests-1: 0, wasm-automated-net9.0-WinUI-RuntimeTests-2: 0

Details

android-28-net8: 32 changed over 829
🚨🚨 Comparison Details (first 20) 🚨🚨
- CommandBar_LongTitle_Validation_Uno_UI_Samples_Content_UITests_CommandBar_CommandBar_LongTitle
- Detereminate_ProgressRing_Validation0_[#FF0000_#FF0000_#FF0000_#FF0000]_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIDeterminateProgressRing
- Detereminate_ProgressRing_Validation50_[#FF0000_#008000_#008000_#FF0000]_Progress-Ring-Value-50
- FrameworkElement_NativeLayout_UITests_Shared_Windows_UI_Xaml_FrameworkElementTests_FrameworkElement_NativeLayout
- ToggleSwitch_IsEnabled_Validation_Uno_UI_Samples_Content_UITests_ButtonTestsControl_ToggleSwitch_IsEnable_Automated
- SelectionTest_UITests_Microsoft_UI_Xaml_Controls_RadioButtonsTests_RadioButtonsPage
- When_Clipped_Rounded_Corners_UITests_Windows_UI_Xaml_Clipping_Clipping4273
- SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
- When_NoSelection_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- When_NoSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- When_ExtendedSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- CommandBar_LongTitle_Validation_CommandBar_-_LongTitle_-_1_-_Initial_State
- ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
- When_MaxLines_Changed_On_Stack_Container_Uno_UI_Samples_Content_UITests_TextBlockControl_SimpleText_MaxLines_Multiple_Containers
- CommandBar_LongTitle_Validation_CommandBar_-_LongTitle_-_2_-_Orientation_Landscape
- Detereminate_ProgressRing_Validation75_[#FF0000_#008000_#008000_#008000]_Progress-Ring-Value-75
- UpDownEnabledTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
- UpDownTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
- When_Parent_PointerMoved_After_drag_on_non-scrolling_ScrollViewer
- When_Parent_PointerMoved_After_drag_on_ScrollViewer_-_touch
android-28-net8-Snap: 52 changed over 1066
🚨🚨 Comparison Details (first 20) 🚨🚨
- GridView_Uno_UI_Samples_Content_UITests_GridView_GridView_Inside_ScrollViewer_Uno_UI_Samples_Content_UITests_GridView_GridView_Inside_ScrollViewer
- ListView_ListView_FirstLastCacheIndex_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_FirstLastCacheIndex
- ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
- ListView_ListViewIncrementalLoading_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewIncrementalLoading
- MenuBar_SimpleMenuBar_UITests_Shared_Windows_UI_Xaml_Controls_MenuBarTests_SimpleMenuBar
- ListView_HorizontalListView_Templates_SamplesApp_Windows_UI_Xaml_Controls_ListView_HorizontalListView_Templates
- MediaPlayerElement_Using_3gp_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_3gp_Extension
- MediaPlayerElement_Using_mp3_Audio_only_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mp3_Extension
- MediaPlayerElement_Using_ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_Extension
- MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal
- RatingControl_UITests_Microsoft_UI_Xaml_Controls_RatingControlTests_RatingControlPage_UITests_Microsoft_UI_Xaml_Controls_RatingControlTests_RatingControlPage
- TabView_UITests_Microsoft_UI_Xaml_Controls_TabViewTests_TabViewPage_UITests_Microsoft_UI_Xaml_Controls_TabViewTests_TabViewPage
- NavigationView_MUXControlsTestApp_NavigationViewCustomThemeResourcesPage_MUXControlsTestApp_NavigationViewCustomThemeResourcesPage
- SwipeControl_MUXControlsTestApp_SwipeControlPage2_MUXControlsTestApp_SwipeControlPage2
- TextBlock_UITests_Shared_Windows_UI_Xaml_Controls_TextBlockControl_TextBlock_Foreground_While_Collapsed_UITests_Shared_Windows_UI_Xaml_Controls_TextBlockControl_TextBlock_Foreground_While_Collapsed
- TextBlock_UITests_Shared_Windows_UI_Xaml_Controls_TextBlockControl_TextBlock_Layout_UITests_Shared_Windows_UI_Xaml_Controls_TextBlockControl_TextBlock_Layout
- TextBlock_UITests_Shared_Windows_UI_Xaml_Controls_TextBlockControl_TextBlock_LineHeight_MultipleControls_UITests_Shared_Windows_UI_Xaml_Controls_TextBlockControl_TextBlock_LineHeight_MultipleControls
- ListView_ListView_With_ListViews_Count_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_Measure
- Scrolling_MUXControlsTestApp_ScrollViewWithScrollControllersPage_MUXControlsTestApp_ScrollViewWithScrollControllersPage
- MUX_UITests_Shared_Microsoft_UI_Xaml_Controls_TreeViewTests_TreeViewPage_UITests_Shared_Microsoft_UI_Xaml_Controls_TreeViewTests_TreeViewPage
ios: 4 changed over 267
🚨🚨 Comparison Details (first 20) 🚨🚨
- ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- When_NoSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- TextBox_UpdatedBinding_On_OneWay_Mode_UITests_Windows_UI_Xaml_Controls_TextBox_TextBox_Bindings
ios-Snap: 53 changed over 1057
🚨🚨 Comparison Details (first 20) 🚨🚨
- ListView_HorizontalListViewGrouped_SamplesApp_Windows_UI_Xaml_Controls_ListView_HorizontalListViewGrouped
- ListView_HorizontalListView_Padding_SamplesApp_Windows_UI_Xaml_Controls_ListView_HorizontalListView_Padding
- ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
- Brushes_RectangleStretchFill_Uno_UI_Samples_UITests_ImageBrushTestControl_RectangleStretchFill
- Brushes_ImageBrushWithScaleTransform_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushWithScaleTransform
- ListView_ListViewHeaderFooter_ImplicitlyBinded_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewHeaderFooter_ImplicitlyBinded
- ListView_ListViewHeaderImage_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewHeaderImage
- ListView_ListView_WithScrollViewer_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_WithScrollViewer
- ListView_ListView_TextBox_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_TextBox
- ListView_ListView_Image_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Image
- NavigationView_MUXControlsTestApp_NavigationViewBlankPage1_MUXControlsTestApp_NavigationViewBlankPage1
- RelativePanel_UITests_Windows_UI_Xaml_Controls_RelativePanelTests_RelativePanel_MultipleCenterAlign_UITests_Windows_UI_Xaml_Controls_RelativePanelTests_RelativePanel_MultipleCenterAlign
- Brushes_ImageBrushLocalAsset_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushLocalAsset
- Buttons_Custom_Button_With_ContentTemplate_Uno_UI_Samples_Content_UITests_ButtonTestsControl_Custom_Button_With_ContentTemplate
- Default_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation
- Image_EmptyImageFixedWidth_Uno_UI_Samples_UITests_ImageTestsControl_EmptyImageFixedWidth
- Brushes_ImageBrushStretch_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushStretch
- Clipping_UITests_Windows_UI_Xaml_Clipping_BorderVisualClipping_UITests_Windows_UI_Xaml_Clipping_BorderVisualClipping
- Grid_CenteredGridinGridwiththreefixedsizechildren_Uno_UI_Samples_Content_UITests_GridTestsControl_CenteredGridinGridwiththreefixedsizechildren
- Image_Image_Stretch_None_ScrollViewer_Uno_UI_Samples_UITests_ImageTestsControl_Image_Stretch_None_Containers
skia-gtk-screenshots: 1798 changed over 2218
🚨🚨 Comparison Details (first 20) 🚨🚨
- AppBar_KeyBoard.png
- AppWindowClosing.png-dark
- ArcSegment.png
- AuthenticationBroker_Demo.png
- AutoSizedPathCentered.png
- AutoSuggestBox_Reason.png
- BasicThemeResources.png
- BorderCenteredwithmargins.png
- BorderImageBrush.png-dark
- Border_CornerRadius_Alignments.png
- Border_CornerRadius_Clipping.png-dark
- Border_With_CompositeTransform.png-dark
- CheckBox_Automated.png-dark
- CheckBox_Automated.png
- ComboBox_Empty.png-dark
- CommandBar_LongTitle_Navigation.png-dark
- CommandBar_LongTitle_Navigation.png
- ContentDialog_Async.png-dark
- ContentDialog_Async.png
- DynamicBackgroundSizing.png-dark
skia-linux-screenshots: 1817 changed over 2218
🚨🚨 Comparison Details (first 20) 🚨🚨
- Application_Window lifecycle events.png-dark
- AppWindowPresenters.png
- Arrange_Performance01.png-dark
- Attributed_text_Supserscript.png-dark
- AuthenticationBroker_Demo.png-dark
- AutoBorderStretchwithleftmargin.png
- AutoBorderStretchwithtopmargin.png-dark
- AutoSuggestBox_Description.png-dark
- AutoSuggestBox_Description.png
- BadgeNotificationTests.png-dark
- Basics.png-dark
- BitmapIcon_Monochromatic.png-dark
- BorderRightwithmargins.png-dark
- BorderRightwithmargins.png
- Border_Clipped_Change_Property.png-dark
- Border_Corner_Overlap.png-dark
- Border_Corner_Overlap.png
- BreadcrumbBarPage.png
- Brushes_ImplicitConvert.png-dark
- CameraCaptureUISample.png
skia-windows-screenshots: 1508 changed over 2218
🚨🚨 Comparison Details (first 20) 🚨🚨
- AppBarButtonWithIconTest.png-dark
- AndroidWindowInsets.png-dark
- AppBarToggleButtonTest.png-dark
- AnimatedIconPage.png-dark
- AppBar_KeyBoard.png
- AppBarButtonTest.png
- Application_Window lifecycle events.png
- AppBar_KeyBoard.png-dark
- ApplicationViewSizing.png-dark
- Arrange_Performance01.png-dark
- ApplicationViewSpanningRectsPage.png
- AppWindowPositionAndSize.png-dark
- AuthenticationBroker_Demo.png
- AppXamlDefinedResources.png-dark
- AutoBorderStretchwithbottommargin.png-dark
- AutoSizedPathCentered.png
- AutoBorderStretchwithbottommargin.png
- AutoSizedTopLeft.png-dark
- AutoBorderStretchwithleftmargin.png-dark
- AutoSuggestBox_SoftKeboard.png
wasm: 190 changed over 1044
🚨🚨 Comparison Details (first 20) 🚨🚨
- SamplesApp.Wasm.Windows_UI_Xaml_Controls.ComboBox.ComboBox_Header
- SamplesApp.Windows_UI_Xaml_Controls.ListView.ListView_ItemClick
- SamplesApp.Windows_UI_Xaml_Controls.ListView.ListView_ItemContainerStyleSelector
- UITests.Shared.Windows_UI_Xaml_Controls.BitmapIconTests.BitmapIcon_Generic
- UITests.Shared.Windows_UI_Xaml_Controls.ListView_Header_DataContextChanging
- UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_Minimal
- UITests.Uno_Web.Http.CookieManagerTests
- UITests.Windows_UI_Xaml.FocusTests.Focus_FocusState
- UITests.Windows_UI_Xaml.FocusTests.Focus_FocusVisual_Properties
- UITests.Windows_UI_Xaml.FocusTests.Focus_VisualStates
- UITests.Windows_UI_Xaml_Controls.ImageTests.Image_Transforms
- UITests.Windows_UI_Xaml_Controls.ImageTests.SvgImageSource_MultiLoad
- SamplesApp.Wasm.Windows_UI_Xaml_Controls.ComboBox.ComboBox_Picker
- SamplesApp.Windows_UI_Xaml.Clipping.DoubleAnimationClipping
- SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewEmptyGroups
- SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewScrollIntoViewSnapPoints
- SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewSelectedItems
- UITests.Windows_UI_Xaml_Controls.CalendarView.CalendarView_Theming
- Uno.UI.Samples.Content.UITests.ButtonTestsControl.Button_Enabled_Control_Disabled
- Uno.UI.Samples.Content.UITests.ButtonTestsControl.Button_IsEnabled_Automated
wasm-automated-net9.0-UWP-Default-automated: 41 changed over 1946
🚨🚨 Comparison Details (first 20) 🚨🚨
- Default_UITests_Windows_UI_Xaml_DragAndDrop_DragDrop_TestPage_UITests_Windows_UI_Xaml_DragAndDrop_DragDrop_TestPage
- ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
- Brushes_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrush_StreamSource_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrush_StreamSource
- Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected
- Default_StrokeThickness_MyEllipse
- NavigationView_MUXControlsTestApp_NavigationViewCustomThemeResourcesPage_MUXControlsTestApp_NavigationViewCustomThemeResourcesPage
- Brushes_Uno_UI_Samples_Samples_Shared_Content_UITests_ImageBrushInList_Uno_UI_Samples_Samples_Shared_Content_UITests_ImageBrushInList
- Default_StrokeThickness_MyPolygon
- Expander_WinUIExpanderPage_UITests_Shared_Microsoft_UI_Xaml_Controls_ExpanderTests_WinUIExpanderPage
- MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal
- MediaPlayerElement_Sources_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Sources
- MediaPlayerElement_Using_3gp_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_3gp_Extension
- MediaPlayerElement_Using_mp3_Audio_only_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mp3_Extension
- MediaPlayerElement_Using_ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_Extension
- ListView_ListView_With_ListViews_Count_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_Measure
- ImageStretch_None_Uno_UI_Samples_UITests_ImageTestsControl_Image_Stretch_None
- Default_StrokeThickness_MyLine_0_StrokeThickness
- ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
- Default_StrokeThickness_MyRect
- Default_StrokeThickness_MyPolyline
wasm-automated-net9.0-UWP-RuntimeTests-0: 0 changed over 1
wasm-automated-net9.0-UWP-RuntimeTests-1: 0 changed over 1
wasm-automated-net9.0-UWP-RuntimeTests-2: 0 changed over 1
wasm-automated-net9.0-WinUI-Benchmarks-automated: 0 changed over 1
wasm-automated-net9.0-WinUI-RuntimeTests-0: 0 changed over 1
wasm-automated-net9.0-WinUI-RuntimeTests-1: 0 changed over 1
wasm-automated-net9.0-WinUI-RuntimeTests-2: 0 changed over 1

fix(codegen): Adjust mvvm toolkit properties discovery

e94127f

github-actions bot added the area/code-generation Categorizes an issue or PR as relevant to code generation label Sep 27, 2024

ajpinedam reviewed Sep 28, 2024

View reviewed changes

...eGenerators.Tests/XamlCodeGeneratorTests/Out/WBOP/XamlCodeGenerator_GlobalStaticResources.cs Show resolved Hide resolved

ajpinedam approved these changes Sep 28, 2024

View reviewed changes

...Generators.Tests/XamlCodeGeneratorTests/Out/WNBOP/XamlCodeGenerator_GlobalStaticResources.cs Show resolved Hide resolved

Youssef1313 approved these changes Sep 28, 2024

View reviewed changes

chore: Adjust test for updated storage

301c1d4

github-actions bot added the area/automation Categorizes an issue or PR as relevant to project automation label Sep 29, 2024

chore: Adjust generation

d2a7841

jeromelaban merged commit c5c91bd into master Sep 29, 2024
110 checks passed

jeromelaban deleted the dev/jela/mvvm-tk-subtypes branch September 29, 2024 14:15

mergify bot mentioned this pull request Sep 29, 2024

fix(codegen): Adjust mvvm toolkit properties discovery (backport #18326) #18334

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(codegen): Adjust mvvm toolkit properties discovery #18326

fix(codegen): Adjust mvvm toolkit properties discovery #18326

jeromelaban commented Sep 27, 2024

jeromelaban commented Sep 27, 2024

mergify bot commented Sep 27, 2024 •

edited

Loading

unodevops commented Sep 27, 2024

unodevops commented Sep 27, 2024

jeromelaban commented Sep 28, 2024

azure-pipelines bot commented Sep 28, 2024

nventive-devops commented Sep 28, 2024

nventive-devops commented Sep 29, 2024

fix(codegen): Adjust mvvm toolkit properties discovery #18326

fix(codegen): Adjust mvvm toolkit properties discovery #18326

Conversation

jeromelaban commented Sep 27, 2024

PR Type

What is the new behavior?

PR Checklist

Other information

jeromelaban commented Sep 27, 2024

mergify bot commented Sep 27, 2024 • edited Loading

✅ Backports have been created

unodevops commented Sep 27, 2024

unodevops commented Sep 27, 2024

jeromelaban commented Sep 28, 2024

azure-pipelines bot commented Sep 28, 2024

nventive-devops commented Sep 28, 2024

nventive-devops commented Sep 29, 2024

mergify bot commented Sep 27, 2024 •

edited

Loading