Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ComboBox.IsEditable #17792

Open
wants to merge 69 commits into
base: master
Choose a base branch
from
Open

feat: ComboBox.IsEditable #17792

wants to merge 69 commits into from

Conversation

MartinZikmund
Copy link
Member

@MartinZikmund MartinZikmund commented Aug 1, 2024 •
edited
Loading

GitHub Issue (If applicable): closes #9063

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@MartinZikmund MartinZikmund changed the title chore: Start IsEditable support for ComboBox [WIP] feat: ComboBox.IsEditable Aug 1, 2024
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17792/index.html

@MartinZikmund MartinZikmund linked an issue Aug 2, 2024 that may be closed by this pull request
ComboBox.IsEditable is not implemented #9063
Open
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17792/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17792/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17792/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17792/index.html

1 similar comment
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17792/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17792/index.html

2 similar comments
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17792/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17792/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17792/index.html

4 similar comments
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17792/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17792/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17792/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17792/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17792/index.html

1 similar comment
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17792/index.html

@github-actions github-actions bot added area/skia ✏️ Categorizes an issue or PR as relevant to Skia area/automation Categorizes an issue or PR as relevant to project automation labels Aug 22, 2024
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17792/index.html

@MartinZikmund
chore: Simulate click on location
ffd79a1
@MartinZikmund
chore: Tunneling events, fixes
2034bc0
@MartinZikmund
chore: Remove legacy key handling on ComboBoxItems
3146d4c
@MartinZikmund
fix: Make KeyboardHelper use async consistently
cb5f0d9
@MartinZikmund
chore: Fix key sequences
91571a6
@MartinZikmund
chore: Adjust KeyboardHelper usages to be awaited
6cc1bbf
@MartinZikmund
chore: Adjustments for CI
acb30ab
@MartinZikmund
chore: CI adjustments
d557f92
@MartinZikmund
chore: Duplicate global
bd66b8f
@MartinZikmund
chore: Never null
c1d588c
@MartinZikmund
chore: Adjust existing IsEditable tests
d5727d8
@MartinZikmund
chore: Continue adjusting existing tests to pass with new logic
5798d55
@MartinZikmund
fix: Uno specific workaround for invalid assert in ComboBox
3f1ac8f
@MartinZikmund
chore: Wrong ported value
0bdc555
@MartinZikmund
chore: Port OnSelectionChanged
e0393d6
@MartinZikmund
chore: Disable popup arrangment test
a724e50
@MartinZikmund
chore: Adjust position of ComboBox popup for editable mode
49c2d4e
@MartinZikmund
chore: Partially port Selector navigation handling
2faacc4
@MartinZikmund
chore: Selection handling on Selector for custom values
a2ca190
@MartinZikmund
fix: Correcly await async RunOnUIThread calls
ddb604d
@MartinZikmund
chore: Disable additional test
b38f860
@MartinZikmund
chore: Adjustments for CI
e8f12c6
@MartinZikmund
chore: Android CI
f092699
@MartinZikmund
chore: Avoid measuring on invalid size
86f3640
@MartinZikmund
chore: Avoid raising Preview key events on unsupported targets
a4146c0
@MartinZikmund
chore: Update diffignore
005ec29
@github-actions github-actions bot added the area/build Categorizes an issue or PR as relevant to build infrastructure label Sep 30, 2024
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17792/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-17792/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carldebilly carldebilly carldebilly left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area/build Categorizes an issue or PR as relevant to build infrastructure area/skia ✏️ Categorizes an issue or PR as relevant to Skia platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ComboBox.IsEditable is not implemented
3 participants
@MartinZikmund @unodevops @carldebilly