Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: templated-parent rework #17645

Open
wants to merge 67 commits into
base: master
Choose a base branch
from
Open

feat!: templated-parent rework #17645

wants to merge 67 commits into from
+3,026 −1,440

Conversation

Xiaoy312
Copy link
Contributor

@Xiaoy312 Xiaoy312 commented Jul 23, 2024 •
edited
Loading

GitHub Issue (If applicable): closes #1621

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

closes #8049, closes #9059, closes #12624, closes #17312, closes #17313

@github-actions github-actions bot added platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform area/skia ✏️ Categorizes an issue or PR as relevant to Skia area/code-generation Categorizes an issue or PR as relevant to code generation area/automation Categorizes an issue or PR as relevant to project automation labels Jul 23, 2024
@Xiaoy312 Xiaoy312 added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. and removed platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform area/skia ✏️ Categorizes an issue or PR as relevant to Skia area/code-generation Categorizes an issue or PR as relevant to code generation area/automation Categorizes an issue or PR as relevant to project automation labels Jul 23, 2024
@Xiaoy312
Copy link
Contributor Author

Xiaoy312 commented Jul 23, 2024 •
edited
Loading

reserving top comment

todo:

  • review: currently pushed code, and mark todos or debug code
  • cherry uno17717 if we want ci to success (or wait until merged & do azp_run
  • build each targets: skia, unit-test, droid, ios, wasm
  • run runtime tests for each targets
  • remaining test failures:
  • legacy support
  • find & check which potentially-tp-related issues are also fixed here, and possibly add a test to confirm
  • wrapping up

document works for follow up PRs or the future:

last completed ci:
^ our builds: https://dev.azure.com/uno-platform/Uno%20Platform/_build?definitionId=5&_a=summary&branchFilter=23731
^ note: DO NOT push anything until a build is fully completed (passing or not), otherwise the build will be canceled and the test records will not be kept... (only needed after changes that could invalidate last completed ci)
^ significant changes since:

@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20240703/templated-parent-rework-v3 branch from 55cbd8a to ace5799 Compare July 24, 2024 15:47
@github-actions github-actions bot added platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform area/skia ✏️ Categorizes an issue or PR as relevant to Skia area/code-generation Categorizes an issue or PR as relevant to code generation area/automation Categorizes an issue or PR as relevant to project automation labels Jul 24, 2024
@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20240703/templated-parent-rework-v3 branch 2 times, most recently from 4c3fd2a to ce157bc Compare July 24, 2024 15:56
@github-actions github-actions bot removed the area/skia ✏️ Categorizes an issue or PR as relevant to Skia label Jul 24, 2024
@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20240703/templated-parent-rework-v3 branch 2 times, most recently from 81b4451 to c0a795e Compare July 25, 2024 00:35
@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20240703/templated-parent-rework-v3 branch from c0a795e to a3a4dc2 Compare July 25, 2024 00:44
Xiaoy312
Xiaoy312 commented Jul 25, 2024
View reviewed changes
src/Uno.UI/UI/Xaml/Media/VisualTreeHelper.Android.cs Outdated Show resolved Hide resolved
src/Uno.UI/UI/Xaml/Controls/Pivot/PivotAdapter.Android.cs Outdated Show resolved Hide resolved
src/Uno.UI/UI/Xaml/Controls/Pivot/PivotItemFragment.Android.cs Outdated Show resolved Hide resolved
src/Uno.UI/UI/Xaml/Controls/Popover/Popover.iOS.cs Outdated Show resolved Hide resolved
src/Uno.UI/UI/Xaml/Controls/ScrollContentPresenter/ScrollContentPresenter.Native.cs Outdated Show resolved Hide resolved
src/Uno.UI/UI/Xaml/FrameworkTemplate.cs Outdated Show resolved Hide resolved
src/Uno.UI/UI/Xaml/FrameworkTemplate.cs Outdated Show resolved Hide resolved
src/Uno.UI/UI/Xaml/FrameworkTemplate.cs Outdated Show resolved Hide resolved
src/Uno.UI/UI/Xaml/ElementStub.Android.cs Show resolved Hide resolved
@github-actions github-actions bot added the platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform label Aug 1, 2024
@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20240703/templated-parent-rework-v3 branch from 7fb3761 to fa63d08 Compare August 1, 2024 20:40
@github-actions github-actions bot added the area/build Categorizes an issue or PR as relevant to build infrastructure label Aug 1, 2024
@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20240703/templated-parent-rework-v3 branch from fa63d08 to a589451 Compare August 2, 2024 16:11
@unoplatform unoplatform deleted a comment from unodevops Sep 26, 2024
@unoplatform unoplatform deleted a comment from unodevops Sep 26, 2024
@unoplatform unoplatform deleted a comment from unodevops Sep 26, 2024
@unoplatform unoplatform deleted a comment from unodevops Sep 26, 2024
@unoplatform unoplatform deleted a comment from unodevops Sep 26, 2024
@unoplatform unoplatform deleted a comment from unodevops Sep 26, 2024
@unoplatform unoplatform deleted a comment from unodevops Sep 26, 2024
@unoplatform unoplatform deleted a comment from unodevops Sep 26, 2024
@unoplatform unoplatform deleted a comment from unodevops Sep 26, 2024
@unoplatform unoplatform deleted a comment from unodevops Sep 26, 2024
@unoplatform unoplatform deleted a comment from unodevops Sep 26, 2024
@unoplatform unoplatform deleted a comment from unodevops Sep 26, 2024
@unoplatform unoplatform deleted a comment from unodevops Sep 26, 2024
@unoplatform unoplatform deleted a comment from unodevops Sep 26, 2024
@unoplatform unoplatform deleted a comment from unodevops Sep 26, 2024
@unoplatform unoplatform deleted a comment from unodevops Sep 26, 2024
@unoplatform unoplatform deleted a comment from unodevops Sep 26, 2024
@unoplatform unoplatform deleted a comment from unodevops Sep 26, 2024
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17645/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-17645/index.html

@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20240703/templated-parent-rework-v3 branch from c1d99c3 to 1596696 Compare September 27, 2024 03:10
@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20240703/templated-parent-rework-v3 branch from 1596696 to 978f52e Compare September 27, 2024 04:52
@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-17645/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17645/index.html

@Xiaoy312 Xiaoy312 marked this pull request as ready for review September 27, 2024 14:31
@nventive-devops
Copy link
Contributor

The build 141453 found UI Test snapshots differences: android-28-net8: 30, android-28-net8-Snap: 69, ios: 13, ios-Snap: 56, skia-gtk-screenshots: 1943, skia-linux-screenshots: 1860, skia-windows-screenshots: 1569, wasm: 531, wasm-automated-net9.0-UWP-Default-automated: 91, wasm-automated-net9.0-UWP-RuntimeTests-0: 0, wasm-automated-net9.0-UWP-RuntimeTests-1: 0, wasm-automated-net9.0-UWP-RuntimeTests-2: 0, wasm-automated-net9.0-WinUI-Benchmarks-automated: 0, wasm-automated-net9.0-WinUI-RuntimeTests-0: 0, wasm-automated-net9.0-WinUI-RuntimeTests-1: 0, wasm-automated-net9.0-WinUI-RuntimeTests-2: 0

Details

  • android-28-net8: 30 changed over 829

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • CommandBar_LongTitle_Validation_Uno_UI_Samples_Content_UITests_CommandBar_CommandBar_LongTitle
    • CommandBar_LongTitle_Validation_CommandBar_-_LongTitle_-_1_-_Initial_State
    • FrameworkElement_NativeLayout_UITests_Shared_Windows_UI_Xaml_FrameworkElementTests_FrameworkElement_NativeLayout
    • Detereminate_ProgressRing_Validation25_[#FF0000_#008000_#FF0000_#FF0000]_Progress-Ring-Value-25
    • ListView_ListViewWithHeader_InitializesTest_SamplesApp_Windows_UI_Xaml_Controls_ListView_HorizontalListViewGrouped
    • NativeCommandBar_Size_Uno_UI_Samples_Content_UITests_CommandBar_CommandBar_Dynamic
    • NavigateBackAndForthBetweenMenuItemsAndSettings_Fluent_SamplesApp_Samples_Microsoft_UI_Xaml_Controls_NavigationViewTests_FluentStyle_FluentStyle_NavigationViewSample
    • WebView_NavigateToLongString_AfterSuccess
    • Pivot_Non_PivotItemChange_Validation_UITests_Shared_Windows_UI_Xaml_Controls_Pivot_Pivot_CustomContent_Automated
    • When_BitmapIcon_Generic_Changed
    • When_BitmapIcon_Generic_Initial
    • When_MultipleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • Pivot_Non_PivotItem_Items_UITests_Shared_Windows_UI_Xaml_Controls_Pivot_Pivot_CustomContent_Automated
    • When_Parent_PointerMoved_After_drag_on_ScrollViewer_-_touch
    • ContentPresenter_Changing_ContentTemplate_Uno_UI_Samples_Content_UITests_ContentPresenter_ContentPresenter_Changing_ContentTemplate
    • Detereminate_ProgressRing_Validation50_[#FF0000_#008000_#008000_#FF0000]_Progress-Ring-Value-50
    • ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
    • ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • When_ExtendedSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers

  • android-28-net8-Snap: 69 changed over 1066

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • ColorPicker_ColorPickerSample_UITests_Microsoft_UI_Xaml_Controls_ColorPickerTests_ColorPickerSample
    • Slider_Slider_Inside_ScrollViewer_Uno_UI_Samples_Content_UITests_Slider_Slider_Inside_ScrollViewer
    • Gesture_Recognizer_Pointer_Events_test_bench_UITests_Shared_Windows_UI_Input_GestureRecognizer_PointersEvents
    • ListView_ListView_With_ListViews_Count_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_Measure
    • MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal
    • ContentPresenter_ContentPresenter_TextProperties_Uno_UI_Samples_Content_UITests_ContentPresenter_ContentPresenter_TextProperties
    • MediaPlayerElement_Using_3gp_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_3gp_Extension
    • MediaPlayerElement_Using_mp3_Audio_only_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mp3_Extension
    • MediaPlayerElement_Using_ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_Extension
    • TeachingTip_UITests_Microsoft_UI_Xaml_Controls_TeachingTipTests_TeachingTipPage_UITests_Microsoft_UI_Xaml_Controls_TeachingTipTests_TeachingTipPage
    • TextBlock_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_BrushColorChanging_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_BrushColorChanging
    • TextBlock_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_Special_Character_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_Special_Character
    • MUX_MUXControlsTestApp_RefreshContainerPage_MUXControlsTestApp_RefreshContainerPage
    • MUX_NumberBox_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
    • TextBox_TextBox_Padding_In_ScrollViewer_Uno_UI_Samples_Content_UITests_TextBoxControl_TextBox_Padding_In_ScrollViewer
    • Icons_UITests_Windows_UI_Xaml_Controls_SymbolIconTests_SymbolIcon_Generic_UITests_Windows_UI_Xaml_Controls_SymbolIconTests_SymbolIcon_Generic
    • MenuBar_SimpleMenuBar_UITests_Shared_Windows_UI_Xaml_Controls_MenuBarTests_SimpleMenuBar
    • TextBlock_UITests_Shared_Windows_UI_Xaml_Controls_TextBlockControl_Foreground_Brushes_UITests_Shared_Windows_UI_Xaml_Controls_TextBlockControl_Foreground_Brushes
    • TextBlock_UITests_Shared_Windows_UI_Xaml_Controls_TextBlockControl_TextBlock_Decorations_UITests_Shared_Windows_UI_Xaml_Controls_TextBlockControl_TextBlock_Decorations
    • TextBlock_UITests_Shared_Windows_UI_Xaml_Controls_TextBlockControl_TextBlock_FontWeight_Dynamic_UITests_Shared_Windows_UI_Xaml_Controls_TextBlockControl_TextBlock_FontWeight_Dynamic

  • ios: 13 changed over 267

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • ImageStretch_None_Uno_UI_Samples_UITests_ImageTestsControl_Image_Stretch_None
    • ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • When_SingleSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • Check_ListView_Swallows_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_Measure
    • ListView_ListViewWithHeader_InitializesTest_SamplesApp_Windows_UI_Xaml_Controls_ListView_HorizontalListViewGrouped
    • When_SingleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • When_MultipleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • Check_ListView_Swallows_Measure_after_scroll
    • TextBox_UpdatedBinding_On_OneWay_Mode_UITests_Windows_UI_Xaml_Controls_TextBox_TextBox_Bindings
    • When_TextSize_Then_RelativeSize_UITests_Windows_UI_Xaml_Controls_TextBlockControl_TextBlock_RelativeTextSize
    • SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
    • When_NoSelection_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers

  • ios-Snap: 56 changed over 1057

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Clipping_SamplesApp_Windows_UI_Xaml_Clipping_XamlButtonWithClipping_Scrollable_SamplesApp_Windows_UI_Xaml_Clipping_XamlButtonWithClipping_Scrollable
    • ContentControl_ContentControl_UnsetContent_GenericApp_Views_Content_UITests_ContentControlTestsControl_ContentControl_UnsetContent
    • ListView_ListViewGroupedChanging_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewGroupedChanging
    • NavigationView_UITests_Microsoft_UI_Xaml_Controls_NavigationViewTests_NavigationViewBasicPage_UITests_Microsoft_UI_Xaml_Controls_NavigationViewTests_NavigationViewBasicPage
    • Brushes_GenericApp_Views_Content_UITests_ImageBrushTestControl_ImageBrush_UniformToFill_GenericApp_Views_Content_UITests_ImageBrushTestControl_ImageBrush_UniformToFill
    • Brushes_GenericApp_Views_Content_UITests_ImageBrushTestControl_BorderImageBrushRelativeTransform_GenericApp_Views_Content_UITests_ImageBrushTestControl_BorderImageBrushRelativeTransform
    • Brushes_Uno_UI_Samples_Samples_Shared_Content_UITests_ImageBrushInList_Uno_UI_Samples_Samples_Shared_Content_UITests_ImageBrushInList
    • Brushes_ImageBrushStretch_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushStretch
    • Brushes_PanelImageBrush_Uno_UI_Samples_UITests_ImageBrushTestControl_PanelImageBrush
    • ColorPicker_WinUIColorPickerPage_UITests_Shared_Microsoft_UI_Xaml_Controls_ColorPickerTests_WinUIColorPickerPage
    • ContentPresenter_ContentPresenter_TextProperties_Uno_UI_Samples_Content_UITests_ContentPresenter_ContentPresenter_TextProperties
    • ContentControl_ContentControl_Nested_TemplatedParent_Uno_UI_Samples_Content_UITests_ContentControlTestsControl_ContentControl_Nested_TemplatedParent
    • Icons_UITests_Shared_Windows_UI_Xaml_Controls_BitmapIconTests_BitmapIcon_Foreground_UITests_Shared_Windows_UI_Xaml_Controls_BitmapIconTests_BitmapIcon_Foreground
    • Image_Image_Stretch_None_ScrollViewer_Uno_UI_Samples_UITests_ImageTestsControl_Image_Stretch_None_Containers
    • Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Smaller_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Smaller
    • Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Taller_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Taller
    • Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Wider_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Wider
    • ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
    • ListView_UITests_Windows_UI_Xaml_Controls_ListView_ListView_DisplayMemberPath_UITests_Windows_UI_Xaml_Controls_ListView_ListView_DisplayMemberPath
    • MUX_UITests_Shared_Microsoft_UI_Xaml_Controls_TreeViewTests_TreeViewPage_UITests_Shared_Microsoft_UI_Xaml_Controls_TreeViewTests_TreeViewPage

  • skia-gtk-screenshots: 1943 changed over 2218

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • AppBarToggleButtonTest.png-dark
    • ApplicationViewSizing.png
    • BackGesture.png-dark
    • Basics_Automated.png
    • BorderBottomwithmargins.png-dark
    • BorderVersusPanelClipping.png-dark
    • Border_CornerRadius_Gradient.png-dark
    • Border_With_Off_Centre_ScaleTransform.png-dark
    • Border_With_Off_Centre_ScaleTransform.png
    • Button_UseUWPDefaultStyles.png-dark
    • Button_UseUWPDefaultStyles.png
    • Clipping652.png
    • ClippingRoundedCorners.png-dark
    • ComboBox_Stretch.png
    • ComboBox_With_ItemTemplate.png-dark
    • ContentControl_UnsetContent.png-dark
    • ContentControl_UnsetContent.png
    • EasClientDeviceInformation.png
    • ElevatedView_BorderThickness.png-dark
    • Flyout_Target.png-dark

  • skia-linux-screenshots: 1860 changed over 2218

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • AndroidWindowInsets.png-dark
    • AnimatedIconPage.png-dark
    • AppBarButtonTest.png-dark
    • AppBarButtonWithIconTest.png-dark
    • AppBarToggleButtonTest.png
    • AppBar_KeyBoard.png
    • ApplicationViewSizing.png-dark
    • Application_Window lifecycle events.png-dark
    • AppWindowPositionAndSize.png
    • AppWindowPresenters.png-dark
    • Attributed_text_FontSize_Changing.png
    • Attributed_text_Simple.png-dark
    • AutoBorderStretchwithtopmargin.png-dark
    • AutoSuggestBox_BitmapIcon.png-dark
    • Basics Pivot Test.png
    • Basics.png-dark
    • BeginTime_MultipleAnimations.png-dark
    • BeginTime_MultipleAnimations.png
    • BitmapImage_vs_SvgImageSource.png-dark
    • BorderWithNullBrushAndNonZeroThickness.png-dark

  • skia-windows-screenshots: 1569 changed over 2218

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • AppBarButtonTest.png-dark
    • AppBarButtonWithIconTest.png-dark
    • AppBarToggleButtonTest.png-dark
    • AppBar_KeyBoard.png
    • ApplicationViewSizing.png-dark
    • Application_Window lifecycle events.png-dark
    • AppWindowPresenters.png-dark
    • ArcSegment.png
    • Arrange_Performance01.png-dark
    • AutoBorderStretchwithleftmargin.png-dark
    • AutoSuggestBox_BitmapIcon.png-dark
    • BasicAutoSuggestBox.png-dark
    • BorderCenteredwithmargins.png-dark
    • BorderTopwithmargins.png-dark
    • Border_Clipped_Change_Property.png-dark
    • Border_CornerRadius_BorderThickness.png-dark
    • Border_Simple_with_non_Uniform_Thickness.png-dark
    • Border_Simple_with_Opacity.png-dark
    • Border_Simple_with_Opacity.png
    • Canvas_In_Canvas.png-dark

  • wasm: 531 changed over 1044

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • MUXControlsTestApp.NavigationViewAnimationPage
    • MUXControlsTestApp.NavigationViewMenuItemStretchPage
    • SamplesApp.Microsoft_UI_Xaml_Controls.WebView2Tests.WebView2_ChromeClient
    • SamplesApp.Samples.UnitTests.HttpUnitTests
    • SamplesApp.Wasm.Windows_UI_Xaml_Controls.ComboBox.ComboBox_FullScreen_Popup
    • SamplesApp.Windows_UI_Xaml.Clipping.Transform_Ellipse_In_Border
    • SamplesApp.Windows_UI_Xaml.Clipping.Transform_Ellipse_in_Canvas
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewDynamicOrientation
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewResizable
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewScrollIntoViewSnapPoints
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListView_Padding_All_Sides
    • SamplesApp.Windows_UI_Xaml_Shapes.PathTestsControl.PathIcon
    • SamplesApp.Windows_UI_Xaml_Shapes.PolylinePage
    • SamplesApp.Windows_UI_Xaml_Shapes.ShapeControlsPage
    • UITests.Microsoft_UI_Xaml_Controls.TreeView.TreeViewBasics
    • UITests.Shared.Windows_UI_Xaml.UIElementTests.UIElement_Layout_Constrains
    • UITests.Shared.Windows_UI_Xaml.UIElementTests.UIElement_Native_Child
    • UITests.Shared.Windows_UI_Xaml_Controls.ListView_OwnContainer_Virtualized
    • UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_Minimal
    • UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_Ogg_Extension

  • wasm-automated-net9.0-UWP-Default-automated: 91 changed over 1946

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Default_UITests_Windows_UI_Xaml_Controls_ListView_ListView_ObservableCollection_CreationCount_UITests_Windows_UI_Xaml_Controls_ListView_ListView_ObservableCollection_CreationCount
    • Expander_WinUIExpanderPage_UITests_Shared_Microsoft_UI_Xaml_Controls_ExpanderTests_WinUIExpanderPage
    • ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
    • ListView_SelectedItem_Both_Selection_Changed
    • ListView_SelectedItem_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_SelectedItem
    • ListView_ListViewContainerFromItem_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewContainerFromItem
    • ListView_ListViewEmptyGroups_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewEmptyGroups
    • ListView_ListViewFirstVisibleIndex_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewFirstVisibleIndex
    • ListView_ListViewResizable_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewResizable
    • ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
    • ContentPresenter_Changing_ContentTemplate_Uno_UI_Samples_Content_UITests_ContentPresenter_ContentPresenter_Changing_ContentTemplate
    • ContentPresenter_ContentPresenter_Background_Uno_UI_Samples_Content_UITests_ContentPresenter_ContentPresenter_Background
    • Focus_UITests_Windows_UI_Xaml_FocusTests_Focus_FocusCycle_UITests_Windows_UI_Xaml_FocusTests_Focus_FocusCycle
    • Focus_UITests_Windows_UI_Xaml_FocusTests_Focus_FocusState_UITests_Windows_UI_Xaml_FocusTests_Focus_FocusState
    • Focus_UITests_Windows_UI_Xaml_FocusTests_Focus_FocusVisual_Properties_UITests_Windows_UI_Xaml_FocusTests_Focus_FocusVisual_Properties
    • CommandBar_Long_Title_Uno_UI_Samples_Content_UITests_CommandBar_CommandBar_LongTitle
    • ListView_ListView_SelectedItem_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_SelectedItem
    • ContentPresenter_ContentPresenter_TextProperties_Uno_UI_Samples_Content_UITests_ContentPresenter_ContentPresenter_TextProperties
    • Focus_UITests_Windows_UI_Xaml_FocusTests_Focus_VisualStates_UITests_Windows_UI_Xaml_FocusTests_Focus_VisualStates
    • Focus_Uno_UI_Samples_Content_UITests_FocusTests_FocusManager_FocusDirection_Uno_UI_Samples_Content_UITests_FocusTests_FocusManager_FocusDirection

  • wasm-automated-net9.0-UWP-RuntimeTests-0: 0 changed over 1

  • wasm-automated-net9.0-UWP-RuntimeTests-1: 0 changed over 1

  • wasm-automated-net9.0-UWP-RuntimeTests-2: 0 changed over 1

  • wasm-automated-net9.0-WinUI-Benchmarks-automated: 0 changed over 1

  • wasm-automated-net9.0-WinUI-RuntimeTests-0: 0 changed over 1

  • wasm-automated-net9.0-WinUI-RuntimeTests-1: 0 changed over 1

  • wasm-automated-net9.0-WinUI-RuntimeTests-2: 0 changed over 1

@MartinZikmund
Copy link
Member

It's green!!!! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromelaban jeromelaban jeromelaban left review comments

@Youssef1313 Youssef1313 Youssef1313 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area/automation Categorizes an issue or PR as relevant to project automation area/build Categorizes an issue or PR as relevant to build infrastructure area/code-generation Categorizes an issue or PR as relevant to code generation area/skia ✏️ Categorizes an issue or PR as relevant to Skia do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform
Projects
None yet
Milestone
No milestone
6 participants
@Xiaoy312 @jeromelaban @unodevops @nventive-devops @MartinZikmund @Youssef1313