Skip to content

Commit

Permalink
chore: misc changes
Browse files Browse the repository at this point in the history
  • Loading branch information
Xiaoy312 committed Sep 26, 2024
1 parent 3928870 commit ee37917
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 7 deletions.
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
#nullable enable
#if false // fixme@xy: to remove the constant; temporarily added to test backward compat
#define USE_NEW_TP_CODEGEN
#endif

using System;
using System.Collections.Generic;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,7 @@ public class Given_FrameworkTemplatePool
//#if __ANDROID__
//[Ignore("https://github.com/unoplatform/uno/issues/13969")]
//#endif
// todo@xy: create new issue and link it here
[Ignore("Template pooling is globally disabled on all-platforms for #13969. With TemplatedParent rework, the recycling part was not re-introduced/updated.")]
[Ignore("#18317 With TemplatedParent rework, the recycling part was not re-introduced/updated.")]
public async Task When_Recycle()
{
using (FeatureConfigurationHelper.UseTemplatePooling())
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ private protected override void OnLoaded()

if (_commandBar == null)
{
commandBar = GetTemplatedParent() as CommandBar; // todo@xy: validate
commandBar = GetTemplatedParent() as CommandBar;
_commandBar = new WeakReference<CommandBar?>(commandBar);
}

Expand Down
1 change: 0 additions & 1 deletion src/Uno.UI/Controls/NativeFramePresenter.iOS.cs
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@ protected override Size ArrangeOverride(Size finalSize)

private protected override void SetTemplatedParentImpl(DependencyObject parent)
{
// todo@xy: review if this makes sense?
base.SetTemplatedParentImpl(parent);

InitializeController(parent as Frame);
Expand Down

0 comments on commit ee37917

Please sign in to comment.