Adding missing template parameters #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Mergifyio backport release/stable/5.3 |
✅ Backports have been created
|
nickrandolph
approved these changes
Aug 23, 2024
dansiegel
added a commit
that referenced
this pull request
Aug 23, 2024
…3/pr-925 Adding missing template parameters (backport #925)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #
PR Type
What kind of change does this PR introduce?
What is the current behavior?
there are 3 template properties that are not defined in the CLI configuration which causes one hidden flag to show up and 2 other properties to use the auto assigned values which aren't desirable.
What is the new behavior?
We now define these 3 properties so that the Bootstrap Version is hidden from the CLI and we have a better flag for Lottie and SVG.