Generate AppIconSet for Desktop on MacOS #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dansiegel
force-pushed
the
dev/ds/desktop-mac-appicons
branch
from
be0d6dd
to
974c397
Compare
jeromelaban
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When generating the App Icon for the Desktop target on MacOS we continue to generate the Windows/WPF app icons
What is the new behavior?
When generating the App Icon for the Desktop target on MacOS we now intercept this and generate an AppIconSet that can be properly used when we package the application.