fix: Set AppWindow.Title to DisplayName #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pictos
reviewed
Jan 23, 2024
the xml nodes are immutable, so after setting the value we should read it again
UnoGeneratePackageAppxManifest doesn't exist on other targets, so we changed the UnoGeneratePackageAppxManifest to depend on _GenerateWindowUnoIconExtension target instead
nickrandolph
approved these changes
Jan 31, 2024
|
Congrats on your first pull-request! We ❤ the people who are involved in this project, and we’d love to pay it forward by sending you some swag. If you have any feedback (or ideas how to improve Uno as a open-source project) please open a feedback issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #208
Replaces #209
PR Type
What kind of change does this PR introduce?
What is the current behavior?
On Windows targets,
AppWindowcurrently lacks a default value for itsTitleproperty.In our task for generating window icon, we form the code to retrieve an
AppWindowfrom the XAMLWindow, using it to conveniently set the generatedicofile.What is the new behavior?
Upon retrieval of
AppWindow, set AppWindow.Title to be the app'sDisplayName. This value is obtained from the XAMLWindowinstance which has a pre-definedTitleproperty. (defaulting toDisplayName)PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable): N/A