Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Improve docs #210

Merged
merged 4 commits into from
Jan 23, 2024
Merged

docs: Improve docs #210

merged 4 commits into from
Jan 23, 2024

Conversation

Youssef1313
Copy link
Member

Fixes: #

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@Youssef1313
Copy link
Member Author

cc @pictos @agneszitte

Copy link
Contributor

@pictos pictos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements, just so comments around the changes

doc/using-uno-resizetizer.md Outdated Show resolved Hide resolved
doc/using-uno-resizetizer.md Outdated Show resolved Hide resolved
doc/using-uno-resizetizer.md Outdated Show resolved Hide resolved
doc/using-uno-resizetizer.md Outdated Show resolved Hide resolved
@Youssef1313
Copy link
Member Author

@pictos Is this good to merge?

@pictos
Copy link
Contributor

pictos commented Jan 22, 2024

@Youssef1313 for me it's good to go, if you want to wait another reviewer it's fine

@pictos pictos merged commit e50494b into unoplatform:main Jan 23, 2024
6 checks passed
@Youssef1313 Youssef1313 deleted the resizetizer-docs branch January 23, 2024 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants