Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add WINDOWS to switch in Serilog HostBuilderExtensions #2492

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

frogcrush
Copy link

GitHub Issue (If applicable): closes #2491

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

#2491

What is the new behavior?

#2491

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Shouldn't introduce any unwanted functionality as on WinUI and -desktop it should be able to write to the app data folder.

@morning4coffe-dev
Copy link
Member

Thank you for your contribution @frogcrush! Can you change the commit to follow the conventional commits also? (stackoverflow.com/a/8981216, conventionalcommits.org/en/v1.0.0)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frogcrush we should avoid making large whitespace changes as part of the PR, just so it's easier to track what are the relevant functional changes made in a commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serilog does not log to file in WinUI
3 participants