Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: HowTo IRouteNotifier #2388

Merged
merged 1 commit into from
Sep 9, 2024
Merged

docs: HowTo IRouteNotifier #2388

merged 1 commit into from
Sep 9, 2024

Conversation

eriklimakc
Copy link
Contributor

@eriklimakc eriklimakc commented Jun 24, 2024 •
edited
Loading

GitHub Issue (If applicable): closes #1679

PR Type

What kind of change does this PR introduce?

  • Documentation content changes

What is the new behavior?

Add docs to the Advanced section of Navigation regarding IRouteNotifier and how to access INavigator through the RouteChanged event.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested with docfx
  • Associated with an issue (GitHub or internal)

@eriklimakc eriklimakc added the kind/documentation Categorizes an issue or PR as relevant to 3rd party dependencies that are consumed by this project label Jun 24, 2024
@eriklimakc eriklimakc self-assigned this Jun 24, 2024
@agneszitte
Copy link
Contributor

agneszitte commented Sep 3, 2024 •
edited
Loading

@eriklimakc what is the status of this PR please ?

@eriklimakc
Copy link
Contributor Author

@eriklimakc what is the status of this PR please ?

@agneszitte I still need to add usage examples for IRouteNotifier, NavigationResponse, INavigator.

@eriklimakc eriklimakc force-pushed the dev/erli/1679-IRouteNotifier branch 2 times, most recently from 34d0e2f to 1ca8980 Compare September 9, 2024 11:26
@eriklimakc eriklimakc marked this pull request as ready for review September 9, 2024 13:57
@kazo0 kazo0 merged commit 34aebc4 into main Sep 9, 2024
9 of 10 checks passed
@kazo0 kazo0 deleted the dev/erli/1679-IRouteNotifier branch September 9, 2024 14:47
@eriklimakc
Copy link
Contributor Author

@Mergifyio backport release/stable/5.0

@mergify Mergify
Copy link

mergify bot commented Sep 26, 2024 •
edited
Loading

backport release/stable/5.0

✅ Backports have been created

  • Backport to branch release/stable/5.0 not needed, change already in branch release/stable/5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazo0 kazo0 kazo0 approved these changes

Assignees

@eriklimakc eriklimakc

Labels
kind/documentation Categorizes an issue or PR as relevant to 3rd party dependencies that are consumed by this project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Navigation][Documentation] Write advanced topic with IRouteNotifier, NavigationResponse, INavigator
3 participants
@eriklimakc @agneszitte @kazo0