Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(EdgeSupport): Add support for the chromium edge #35

Merged
merged 10 commits into from
Aug 10, 2023

Conversation

dr1rrb
Copy link
Member

@dr1rrb dr1rrb commented Apr 21, 2020

Feature

Add ability to run UI test using the new Edge browser (a.k.a. Edge dev)

(Also bug fix for #85 )

What is the current behavior?

We can run UI test only using Chrome

What is the new behavior?

We can also run them on Edge

PR Checklist

  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Contains NO breaking changes
  • Associated with an issue (GitHub or internal)

@dr1rrb
Copy link
Member Author

dr1rrb commented Apr 22, 2020

/azp run

@dr1rrb dr1rrb force-pushed the dev/dr/Edge branch 2 times, most recently from f7de3bc to 38a2686 Compare April 22, 2020 20:30
@CLAassistant
Copy link

CLAassistant commented Jun 10, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@marcelwgn marcelwgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't talk about the CI changes or things related to the test, but the selenium driver part looks good to me.

src/Uno.UITest.Puppeteer/SeleniumDriverManager.cs Outdated Show resolved Hide resolved
Install Selenium 4.0-alpha-5 in order to be able to support the chromium edge browser
Remove the launchsettings.json from the .gitignore
Enable the WASM debugger
Fix the TextBox_Test_02.xaml that was using a 2-way x:Bind without BindBack method, which is invalid and now throws at compile time.
@nickrandolph nickrandolph merged commit 9669fd2 into master Aug 10, 2023
8 checks passed
@nickrandolph nickrandolph deleted the dev/dr/Edge branch August 10, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants