-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(EdgeSupport): Add support for the chromium edge #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carldebilly
approved these changes
Apr 21, 2020
/azp run |
dr1rrb
force-pushed
the
dev/dr/Edge
branch
2 times, most recently
from
April 22, 2020 20:30
f7de3bc
to
38a2686
Compare
marcelwgn
approved these changes
May 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't talk about the CI changes or things related to the test, but the selenium driver part looks good to me.
Install Selenium 4.0-alpha-5 in order to be able to support the chromium edge browser Remove the launchsettings.json from the .gitignore Enable the WASM debugger Fix the TextBox_Test_02.xaml that was using a 2-way x:Bind without BindBack method, which is invalid and now throws at compile time.
nickrandolph
force-pushed
the
dev/dr/Edge
branch
from
August 7, 2023 14:21
6e48c73
to
657f868
Compare
nickrandolph
force-pushed
the
dev/dr/Edge
branch
from
August 7, 2023 14:21
657f868
to
ef77005
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
Add ability to run UI test using the new Edge browser (a.k.a. Edge dev)
(Also bug fix for #85 )
What is the current behavior?
We can run UI test only using Chrome
What is the new behavior?
We can also run them on Edge
PR Checklist
Tests for the changes have been added (for bug fixes / features) (if applicable)Associated with an issue (GitHub or internal)