[Commerce App] chore: updating Uno Sdk #790
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Make sure to remove the versions in Directory.Build.props as well |
Kunal22shah
force-pushed
the
dev/ks/Commerce-updateSdk
branch
from
61cdf6e
to
fba4d82
Compare
|
@Kunal22shah could you update the PR titles to include the name of the sample being updated? Thanks! |
Kunal22shah
changed the title
|
@jeromelaban should be good now. Thanks! |
agneszitte
approved these changes
Aug 13, 2024
|
FYI @Kunal22shah there are some CI build errors, if you can take a look please |
agneszitte
reviewed
Aug 13, 2024
Co-authored-by: Agnès ZITTE <[email protected]>
|
@Kunal22shah there's still a build error with themes, which may be related to separate versions in class libraries? @kazo0 may have more information. |
|
I believe we would need to update the CI scripts to use a later ios sdk, no? |
|
@Kunal22shah I am closing this PR as work is done with #831 and #835 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #785