Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ToDo sample app singleproject #745

Merged
merged 26 commits into from
Jun 20, 2024
Merged

feat: ToDo sample app singleproject #745

merged 26 commits into from
Jun 20, 2024

Conversation

rajamatt
Copy link
Contributor

@rajamatt rajamatt commented Jun 6, 2024 •
edited
Loading

@rajamatt rajamatt self-assigned this Jun 6, 2024
@agneszitte agneszitte mentioned this pull request Jun 6, 2024
Closed
@agneszitte agneszitte requested a review from kazo0 June 6, 2024 15:23
@agneszitte agneszitte mentioned this pull request Jun 10, 2024
Closed
@rajamatt
Copy link
Contributor Author

rajamatt commented Jun 12, 2024 •
edited
Loading

What's left:

@rajamatt rajamatt marked this pull request as ready for review June 12, 2024 19:59
@kazo0
Copy link
Contributor

kazo0 commented Jun 14, 2024

@rajamatt I'm getting a crash on Windows when I resize the window to have a small width while on the main page after clicking Get Started

@kazo0
Copy link
Contributor

kazo0 commented Jun 14, 2024

@rajamatt

Light and Dark are inversed

Recording.2024-06-14.103805.mp4

@kazo0
Copy link
Contributor

kazo0 commented Jun 17, 2024

@rajamatt we should add the .vscode folder like we do here: https://github.com/unoplatform/Uno.Samples/tree/master/reference/Counter/XAML-MVUX/.vscode

@kazo0
Copy link
Contributor

kazo0 commented Jun 17, 2024 •
edited by rajamatt
Loading

@rajamatt when I nav to the Tasks page and then navigate back with the back button, it keeps re-navigating to the Tasks page:

This isn't happening on Android?

Simulator Screen Recording - iPhone 15 Pro Max - 2024-06-17 at 15 43 08

@rajamatt
Copy link
Contributor Author

rajamatt commented Jun 17, 2024 •
edited
Loading

@rajamatt when I nav to the Tasks page and then navigate back with the back button, it keeps re-navigating to the Tasks page:

This isn't happening on Android?

No I can't seem to repro this on Android

@rajamatt rajamatt force-pushed the dev/mara/todo-singleproject branch from 48319af to 31d3e5e Compare June 17, 2024 20:28
@kazo0
Copy link
Contributor

kazo0 commented Jun 18, 2024

@rajamatt when I nav to the Tasks page and then navigate back with the back button, it keeps re-navigating to the Tasks page:
This isn't happening on Android?

No I can't seem to repro this on Android

Strange, ok I will investigate a bit on my side and see what's happening

@rajamatt
Copy link
Contributor Author

rajamatt commented Jun 18, 2024 •
edited
Loading

There's also this problem which I just created an issue for: (it is happening on master too) #759

@agneszitte agneszitte mentioned this pull request Jun 20, 2024
Open
@agneszitte
Copy link
Contributor

agneszitte commented Jun 20, 2024 •
edited
Loading

@rajamatt when I nav to the Tasks page and then navigate back with the back button, it keeps re-navigating to the Tasks page:

@kazo0, @rajamatt separated issue opened: #764

@agneszitte agneszitte merged commit 257f0d5 into master Jun 20, 2024
7 checks passed
@agneszitte agneszitte deleted the dev/mara/todo-singleproject branch June 20, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agneszitte agneszitte agneszitte left review comments

@kazo0 kazo0 kazo0 approved these changes

Assignees

@rajamatt rajamatt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rajamatt @kazo0 @agneszitte