Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TabbarItem with Neumorphic Style crash on Windows #1116

Merged
merged 3 commits into from
Jun 17, 2024

Conversation

morning4coffe-dev
Copy link
Member

GitHub Issue (If applicable): closes #1106

PR Type

What kind of change does this PR introduce?

  • Bugfix

This should fix the issue with #1106, once this unoplatform/uno.toolkit.ui#1142 PR is merged.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested on iOS.
  • Tested on Wasm.
  • Tested on Android.
  • Tested on UWP.
  • Tested in both Light and Dark themes.
  • Associated with an issue (GitHub or internal)

Copy link

github-actions bot commented Jun 4, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-1116.eastus2.3.azurestaticapps.net

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-1116.eastus2.3.azurestaticapps.net

@morning4coffe-dev morning4coffe-dev marked this pull request as ready for review June 16, 2024 21:06
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-1116.eastus2.3.azurestaticapps.net

@morning4coffe-dev
Copy link
Member Author

This PR fixes the crash TabBar and FAB Neumorphic sample on Windows. The InfoBadge is currently not used within the Neumorphic sample.

@kazo0
Copy link
Contributor

kazo0 commented Jun 17, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@agneszitte agneszitte merged commit 163d3ca into master Jun 17, 2024
14 of 16 checks passed
@agneszitte agneszitte deleted the dev/doti/tbi-ns-crash-fix branch June 17, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants