fix(cli): respect custom buildDir option for tasks sub command
#2635
+8
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated list & run to get a nitro instance and grab the buildDir from the nitro options and at the close the nitro instance.
pi0
changed the title
buildDir option
pi0
changed the title
buildDir optionbuildDir option for tasks sub command
pi0
reviewed
Jul 26, 2024
src/cli/commands/task/list.ts
Outdated
| @@ -16,13 +16,17 @@ export default defineCommand({ | |||
| }, | |||
| async run({ args }) { | |||
| const cwd = resolve((args.dir || args.cwd || ".") as string); | |||
| const tasks = await listTasks({ cwd, buildDir: ".nitro" }); | |||
| const nitro = await createNitro({ rootDir: cwd }); | |||
There was a problem hiding this comment.
I think you can use lighter loadConfig to load nitro config only
There was a problem hiding this comment.
i used the loadOptions() because i couldn't find an example on the loadConfig function.
I hope that's okay.
|
@pi0 is this good? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated list & run to get a nitro instance and grab the buildDir from the nitro options and at the close the nitro instance.
🔗 Linked issue
#2634 Task cli forces .nitro as buildDir
❓ Type of change
📚 Description
Changes
In run.ts & list.ts from the task command i used
createNitro()to have a nitro instance so i could access the options.i use the
nitro.options.builDirto replace the hardcoded".nitro"buildDir that is passed to the runTask function.at the end of the command run function i also close the the nitro instance that i created.
Why
Now if your
buildDirin thenitro.config.tsis not the default .nitro directory instead of getting an error it uses the correct buildDir and your command will run.This will also make sure that the task cli works with nuxt, because nuxt uses the the buildDir .nuxt.
📝 Checklist