Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSR version should be set to zero #243

Merged
merged 1 commit into from
Sep 30, 2024
Merged

CSR version should be set to zero #243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/acme/client/certificate_request.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ def generate
end
csr.public_key = @private_key
csr.subject = generate_subject
csr.version = 2
csr.version = 0
add_extension(csr)
csr.sign @private_key, @digest
end
Expand Down
6 changes: 6 additions & 0 deletions spec/certificate_request_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,4 +145,10 @@

expect(request.csr.verify(ec_key)).to be(true)
end

it 'generate the request with version zero' do
request = Acme::Client::CertificateRequest.new(common_name: 'example.org', private_key: test_key)

expect(request.csr.version).to be_zero
end
end