Pop open the terminal and run UCM if we dont find it #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… try to reopen the terminal when you close it
tapegram
commented
Nov 4, 2022
package-lock.json
Outdated
| @@ -1,1646 +1,8 @@ | |||
| { | |||
There was a problem hiding this comment.
I don't really know what's going on in here. I think I have an older version of npm installed so it set the lockfile version back when i did npm install. Not sure why the packages changed though. LMK if I should revert the changes to this file or something.
ChrisPenner
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial implementation of #6
This PR will automatically open the embedded terminal and try to run UCM if we weren't able to find a running process to connect to.
We will only try this 1 time to avoid shenanigans or needing to worry about accidentally getting stuck in weird loops.
This makes no attempt to address the problem if UCM isn't installed at all. Hopefully, this will make it a little clearer that maybe UCM is not on the PATH? It might be nice in the future to show a nice message with a link to installation instructions.
This behavior can be disabled via a configuration (
unison.automaticallyOpenUCM)Video examples
Happy path + quitting UCM doesn't result in the extension starting it again
Screen.Recording.2022-11-03.at.6.27.29.PM.mov
"Simulating" UCM not being on the PATH
Screen.Recording.2022-11-03.at.6.28.11.PM.mov