bugfix: tweak suffixify by hash logic #5360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchellwrosen
force-pushed
the
fix-5357
branch
from
1e414ea
to
7827f9f
Compare
aryairani
approved these changes
Sep 20, 2024
mitchellwrosen
added
the
ready-to-merge
mergify
bot
removed
the
ready-to-merge
This was referenced Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #5357
This PR adds a new "suffixify by hash name" suffixification strategy, which we use whenever rendering definitions to a file.
It's like "suffixify by hash", but won't pick a suffix if it has 2+ matching names where 1+ of them are outside
lib. This is because we can't refer to such terms by this suffix if they're in a file.Test coverage
I've added a transcript