feat(hubble): make log levels a bit better

unionlabs · Apr 5, 2024 · 1ed2f3b · 1ed2f3b
1 parent 74ed1fe
commit 1ed2f3b
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/dictionary.txt b/dictionary.txt
@@ -684,6 +684,7 @@ repellendus
 repr
 reqwest
 restaking
+retryable
 rgba
 ripemd
 rlib

diff --git a/hubble/src/eth.rs b/hubble/src/eth.rs
@@ -130,6 +130,12 @@ async fn index_blocks(
         .try_chunks(200)
         .map_err(|err| err.1)
         .try_fold(pool, |pool, chunk| async {
+            info!(
+                chain_id.canonical,
+                "indexing blocks for chunk: {}..{}",
+                &chunk.first().unwrap(),
+                &chunk.last().unwrap()
+            );
             let tx = pool.begin().await.map_err(Report::from)?;
             let inserts = FuturesOrdered::from_iter(
                 chunk
@@ -145,7 +151,7 @@ async fn index_blocks(
                             return Err(err);
                         }
                         Ok(info) => {
-                            info!(
+                            debug!(
                                 chain_id.canonical,
                                 height = info.height,
                                 hash = info.hash,
@@ -295,7 +301,7 @@ impl BlockInsert {
             match Self::from_provider(chain_id, height, provider).await {
                 Ok(block) => return Ok((count, block)),
                 Err(err) => {
-                    if !err.retryable() && count > max_retries {
+                    if !err.retryable() || count > max_retries {
                         return Err(err.into());
                     }
                     count += 1;

diff --git a/hubble/src/postgres.rs b/hubble/src/postgres.rs
@@ -59,7 +59,7 @@ pub struct Log<Chain: ChainType, T> {
 }
 
 /// ChainIds track both the database ID of a chain, as well as some canonical representation for
-/// degug logging
+/// debug logging.
 ///
 /// # Implementation Detail
 /// ChainIds contain leaked values, hence care should be taken when creating them.