Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable isort and run on codebase #1295

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

nathanjmcdougall
Copy link
Contributor

At the moment, isort isn't running because of the --diff option which effectively turns it into a print-only tool. The pre-commit doesn't actually print anything though, and it doesn't raise any exit code so the pre-commit, CI etc. will pass even when the tool thinks things are unsorted.

Similar to #1292, I suggest moving the configuration out of the pre-commit config file (and also setup.cfg) and into pyproject.toml.

I've run isort across the entire codebase, so a lot of files have changed (only cosmetically, of course).

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (7a20c7a) 94.28% compared to head (006dafa) 77.13%.

Files Patch % Lines
pandera/pyspark.py 0.00% 3 Missing ⚠️
pandera/typing/pandas.py 60.00% 2 Missing ⚠️
pandera/api/pyspark/container.py 0.00% 1 Missing ⚠️
pandera/backends/pyspark/column.py 0.00% 1 Missing ⚠️
pandera/backends/pyspark/components.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1295       +/-   ##
===========================================
- Coverage   94.28%   77.13%   -17.15%     
===========================================
  Files          91       91               
  Lines        7013     7011        -2     
===========================================
- Hits         6612     5408     -1204     
- Misses        401     1603     +1202     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nathanjmcdougall added a commit to nathanjmcdougall/pandera that referenced this pull request Aug 8, 2023
That is for files with pre-3.9 annotations with view to migrate
Incidentally run isort (see unionai-oss#1295)

Signed-off-by: Nathan McDougall <[email protected]>
@cosmicBboy
Copy link
Collaborator

hey @nathanjmcdougall would you mind taking a look at some of the merge conflicts? Not sure what was added/reordered by isort

@nathanjmcdougall
Copy link
Contributor Author

@cosmicBboy I've taken a look - unfortunately seems there's an issue with attribute access in one of the doctests - as far as I can tell this is unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants