Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(library): Introduce WAMR #7

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

razvand
Copy link
Contributor

@razvand razvand commented Oct 31, 2023

Introduce WAMR (Wasm Micro Runtime) native application for Unikraft. The version used is an older commit (pre-stable release): bc762f.

Add required files: Kraftfile, Makefile.uk and README.md.

The root filesystem (in rootfs/) provides the pre-built main.wasm file, passed to as the cmd in Kraftfile.

@razvand razvand added the enhancement New feature or request label Oct 31, 2023
@razvand razvand requested a review from nderjung October 31, 2023 11:26
@nderjung
Copy link
Member

nderjung commented Nov 2, 2023

Hi, can you remove the rootfs (since it's a compiled binary, these should stay out of the tree). We can add an example later on that builds one and uses this as a base.

Could you please also add a workflow for this?

Additionally, the use of the version bc762f is not very friendly. I looked up this commit, and it's part of one of the earliest releases of WAMR back in 2019. Maybe let's call this image unikraft.org/wamr:2019 ?

@razvand razvand force-pushed the razvand/library/wamr branch 2 times, most recently from 25d57dc to 09eeffc Compare December 20, 2023 07:48
Copy link
Member

@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine with the local build, the README needs to be updated with the build/run commands like in the other prs, rebased etc.

Introduce WAMR (Wasm Micro Runtime) native application for Unikraft. The
version used is an older commit (pre-stable release): `bc762f`.

Add required files: `Kraftfile`, `Makefile.uk` and `README.md`.

The root filesystem (in `rootfs/`) provides the pre-built `main.wasm`
file, passed to as the `cmd` in `Kraftfile`.

Signed-off-by: Razvan Deaconescu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Progress
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants