Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(examples): Improve http-python3.10 README #68

Merged

Conversation

razvand
Copy link
Contributor

@razvand razvand commented Mar 5, 2024

Improve README.md of http-python3.10 example:

  • Remove trailing whitespaces.
  • Use --rm option to kraft run by default.
  • Update broken link referencing BuildKit.
  • Use backticks for "command formatting" for kraft and sudo.

Improve `README.md` of `http-python3.10` example:

* Remove trailing whitespaces.
* Use `--rm` option to `kraft run` by default.
* Update broken link referencing `BuildKit`.
* Use backticks for "command formatting" for `kraft` and `sudo`.

Signed-off-by: Razvan Deaconescu <[email protected]>
@razvand razvand added documentation Improvements or additions to documentation enhancement New feature or request labels Mar 5, 2024
@razvand razvand requested a review from felipehuici March 5, 2024 08:27
Copy link
Member

@felipehuici felipehuici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Felipe Huici [email protected]
Approved-by: Felipe Huici [email protected]

@felipehuici felipehuici merged commit a83c14d into unikraft:main Mar 5, 2024
0 of 2 checks passed
@razvand razvand deleted the razvand/improve-http-python-readme branch March 5, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

2 participants