Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(library): Add support for Caddy #12

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

razvand
Copy link
Contributor

@razvand razvand commented Nov 14, 2023

Introduce Caddy bincompat run. Build Caddy as static PIE using a Dockerfile, inspired by Caddy's own Docker setup. Use xcaddy to build. The build uses binary compatibility mode (i.e. the base image).

Add:

  • Kraftfile: build / run rules, including pulling the base image
  • Dockerfile: base filesystem, with binary and libraries
  • README.md: document how to use
  • Caddyfile: Caddy configuration file

@razvand razvand added the enhancement New feature or request label Nov 14, 2023
@razvand razvand force-pushed the razvand/library/caddy branch 3 times, most recently from 505c567 to da99861 Compare November 17, 2023 10:01
@razvand razvand force-pushed the razvand/library/caddy branch 4 times, most recently from 0cfedfc to 2d176d3 Compare December 20, 2023 07:47
@nderjung nderjung force-pushed the razvand/library/caddy branch 4 times, most recently from 5123081 to 7d3812c Compare December 21, 2023 17:19
Copy link
Member

@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README needs to be updated with the build and run commands like the other prs. Everything else works.

Copy link
Member

@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment, all good besides that.

library/caddy/2.7/README.md Outdated Show resolved Hide resolved
Copy link
Member

@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get this error when running

en1: Interface is up
[    0.103447] ERR:  [libdevfs] Failed to create /dev: 20
[    0.106231] ERR:  [libukboot] Init function at 0x11bfa0 returned error -1

Introduce Caddy 2.7 image (ELF Loader) for bincompat runs.

Add `Kraftfile` to build for QMEU and Firecracker on x86_64 using
embedded initrd. The current build uses embedded initrd to build
a single image consisting of both the kernel and the initial ramdisk.

Add GitHub workflow to build and deploy the image. Add success badge in
`README.md`.

Signed-off-by: Razvan Deaconescu <[email protected]>
Co-authored-by: Alexander Jung <[email protected]>
Copy link
Member

@nderjung nderjung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@nderjung nderjung merged commit 2c83d2e into unikraft:main Feb 21, 2024
3 of 5 checks passed
@razvand razvand deleted the razvand/library/caddy branch March 4, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants