Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(library): Add httpbingo service as library #113

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(library): Add httpbingo service as library #113

wants to merge 1 commit into from

Conversation

hchandad
Copy link
Contributor

Introduce the httpbingo service as a library A golang port of the httpbin.org HTTP request & response testing service, the changes includes the following

  • a Kraftfile (based on caddy/2.7)
  • a Dockerfile for building the rootfs
  • a .github/workflow build file
  • a new entry to the list in README.md

@hchandad
feat(library): Add httpbingo service as library
8d20819 
Introduce the https://httpbingo.org service as a library
A golang port of the httpbin.org HTTP request & response testing service.

Signed-off-by: Hamza Chandad <[email protected]>
@razvand razvand requested a review from StefanJum August 22, 2024 07:39
@razvand razvand self-assigned this Aug 22, 2024
@razvand razvand added the enhancement New feature or request label Aug 22, 2024
StefanJum
StefanJum requested changes Aug 22, 2024
View reviewed changes
Copy link
Member

@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hchandad, this works fine.

Only one comment, can you move the Run and Use README section down to Build and Run Locally and remove the long run command, since that fails?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanJum StefanJum StefanJum requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@razvand razvand

Labels
enhancement New feature or request
Projects
(Binary) Application Compatibility
Status: No status
Release - Next
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hchandad @StefanJum @razvand